-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monkeys now use filters & Simians are now monkeys #3737
Closed
JohnFulpWillard
wants to merge
17
commits into
Monkestation:master
from
JohnFulpWillard:simian-monkey
Closed
Monkeys now use filters & Simians are now monkeys #3737
JohnFulpWillard
wants to merge
17
commits into
Monkestation:master
from
JohnFulpWillard:simian-monkey
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3585b0a.
lgtm gonna add to tm for a few rounds |
This makes it not work in pref menu properly but should hopefully cut down on the amount of times it gets called.
This was referenced Oct 15, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#81598 which uses filters to allow monkeys to wear any clothes, and makes Simians a subtype of monkeys.
Simians now inherit the height filters among other monkey things like attack chain.
Ignore the half-opaque pixels sticking out the sides, it has been fixed.
The prefs menu's tail icons looks a little fucked up on local but I was told this is apparently normal and is fine on the server. For some reason, it loads just fine when running unit tests locally, so I used that to ensure they look right at the very least.
Why It's Good For The Game
Simians seems like just Monkey+ so why not just make it so, cuts down on some copy paste and should make it easier to change monkeys without having to mirror everything for Simians.
If Teratoma is changed in the future do to similar to this PR then you can also remove the need for
BODYTYPE_CUSTOM
Otherwise this just grants the benefits of the PR posted, monkeys can now wear any suit rather than only the waiter one, simians don't need every single outfit resprited to their body, etc.
Changelog
🆑
add: Monkeys can now wear any outfit rather than just the waiter outfit.
add: Simians now use the same height filter system as Monkeys to wear outfits instead of having their own icon for each individual piece of clothing.
add: Monkeys and Simians can now have eachother's tails, monkey tails are always brown while Simian tails inherit your fur color.
add: Simians and monkeys are now at the bottom of the tile they are on, rather than the middle.
del: Big legged species and monkey abominations.
/:cl: