Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkeys now use filters & Simians are now monkeys #3737

Closed

Conversation

JohnFulpWillard
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard commented Oct 8, 2024

About The Pull Request

Ports tgstation/tgstation#81598 which uses filters to allow monkeys to wear any clothes, and makes Simians a subtype of monkeys.
Simians now inherit the height filters among other monkey things like attack chain.

Ignore the half-opaque pixels sticking out the sides, it has been fixed.
image

The prefs menu's tail icons looks a little fucked up on local but I was told this is apparently normal and is fine on the server. For some reason, it loads just fine when running unit tests locally, so I used that to ensure they look right at the very least.

Why It's Good For The Game

Simians seems like just Monkey+ so why not just make it so, cuts down on some copy paste and should make it easier to change monkeys without having to mirror everything for Simians.
If Teratoma is changed in the future do to similar to this PR then you can also remove the need for BODYTYPE_CUSTOM

Otherwise this just grants the benefits of the PR posted, monkeys can now wear any suit rather than only the waiter one, simians don't need every single outfit resprited to their body, etc.

Changelog

🆑
add: Monkeys can now wear any outfit rather than just the waiter outfit.
add: Simians now use the same height filter system as Monkeys to wear outfits instead of having their own icon for each individual piece of clothing.
add: Monkeys and Simians can now have eachother's tails, monkey tails are always brown while Simian tails inherit your fur color.
add: Simians and monkeys are now at the bottom of the tile they are on, rather than the middle.
del: Big legged species and monkey abominations.
/:cl:

@dwasint
Copy link
Collaborator

dwasint commented Oct 13, 2024

lgtm gonna add to tm for a few rounds

@Absolucy
Copy link
Collaborator

potentially causing lag during TMs:
image

This makes it not work in pref menu properly but should hopefully cut down on the amount of times it gets called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants