The heretic living heart now uses appearance cloning instead of getFlatIcon #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
this gets rid of the getFlatIcon used in the living heart (used to display the target's appearance in the radial menu), and instead uses appearance cloning.
this allows us to ensure the target always appears to be facing south without pixel offsets, with very little performance impact.
2024-10-16.1729101183.dreamseeker.mp4
Why It's Good For The Game
means that the appearance of the target will always be up-to-date whenever living heart is used, and it's far more performant.
Changelog
🆑
qol: The heretic living heart now displays up-to-date appearances of its targets when used.
/:cl: