Local catgirl fixes another batch of minor issues #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2024
Absolucy
force-pushed
the
yup-more-fixes-meow
branch
from
e9f5661
to
2405f9d
Compare
## About The Pull Request Fixes #72053 the signaller is made part of the machine's `component_parts` now so it doesn't get moved out when `dump_inventory_contents()` is called like in the case of microwave when it has finished cooking This fix also applies for other machine's that call this proc Fixes #72132 Clear's out the `holder` & `connected` vars from the signaller when the wire's get destroyed allowing the signaller to be picked up ## Changelog :cl: fix: microwave's(after it has finished cooking) & other machine's that spit out contents don't spit out assemblies/signallers attached to it's wires. fix: signallers can be picked up if you attached them to a machine's wire & later deconstructed that machine without detaching it first. /:cl: --------- Co-authored-by: Jeremiah <[email protected]>
Absolucy
force-pushed
the
yup-more-fixes-meow
branch
from
2405f9d
to
5193934
Compare
This was referenced Oct 23, 2024
…ness when window sills are involved.
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports tgstation/tgstation#75928
Fixes #2988
Fixes #3696
Fixes #3835
Changelog
🆑
fix: Fixed some various minor runtime errors.
fix: Fixed blood deficiency's interaction with oozelings.
fix: Fixed RCDs having trouble constructing windows, and their general jankiness when window sills are involved.
fix: (SyncIt21) Microwaves (after it has finished cooking) & other machines that spit out contents don't spit out assemblies / signalers attached to it's wires.
fix: (SyncIt21) Signalers can be picked up if you attached them to a machine's wire & later deconstructed that machine without detaching it first.
/:cl: