Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track subsystem runtimes via usr #4110

Closed
wants to merge 1 commit into from

Conversation

Absolucy
Copy link
Collaborator

@Absolucy Absolucy commented Nov 5, 2024

About The Pull Request

Port of my own upstream PR, tgstation/tgstation#87448

This adds a dummy "subsystem tracker" mob to every subsystem - which is set to usr during SS preinit, init and fire. (surely this can't go wrong at all)

If usr is a subsystem tracker during a runtime, it'll replace usr: blahblahblah in the runtime text with subsystem: SSwhatever (/datum/controller/subsystem/whatever)

Also, this makes a /mob/abstract type, and repaths /mob/oranges_ear to /mob/abstract/oranges_ear, so that it can share the "technically this is mob but it's not really a mob" behavior with the dummy tracker mob.

Also, I made it add the subsystem type to the structured logging data for runtimes.

blame MSO.

Why It's Good For The Game

makes runtimes slightly easier to read

2024-10-24 (1729820355) ~ dreamseeker

Changelog

not user-facing.

@Absolucy
Copy link
Collaborator Author

Absolucy commented Nov 5, 2024

catgirl accidentally causes worst warops round ever, asked to never do this again

@Absolucy Absolucy closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant