Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add basic progress indicator & activity info #33

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

psobolewskiPhD
Copy link
Contributor

This is a basic attempt at addressing #27
and showing some status/busy info the napari gui.
The potentially long running tasks will now show an indicator that something is happening (the neato moving boxes in the lower right)
Additionally, a notification is provided of the main tasks after click run: (down)loading models and running segmentation
image

cc: @kandarpksk

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #33 (4e1ba9e) into main (6993bee) will decrease coverage by 0.34%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   59.91%   59.57%   -0.34%     
==========================================
  Files           3        3              
  Lines         232      235       +3     
==========================================
+ Hits          139      140       +1     
- Misses         93       95       +2     
Impacted Files Coverage Δ
cellpose_napari/_dock_widget.py 53.06% <66.66%> (-0.31%) ⬇️

@psobolewskiPhD
Copy link
Contributor Author

Test fails seem to be due to: napari/napari#4747 (comment)
Maybe should just drop python 3.7 tests? and add linux?

@tlambert03
Copy link
Collaborator

Maybe should just drop python 3.7 tests? and add linux?

I can't see the direct connection to the importlib-metadata issue mentioned in that comment, but yes, if we're not explicitly pinning the napari dependency here to v0.14.4 (the last one to support 3.7), then i wouldn't expect any tests to work on 3.7. go ahead and drop

@psobolewskiPhD
Copy link
Contributor Author

Hi @tlambert03 the python 3.7 tests are actually running in napari 0.4.14, but failing due to the importlib_metadata issue. Anyhow, I will make a separate PR to try to try to drop 3.7 and add linux? I can probably copy-pasta from the cookiecutter 😉

@psobolewskiPhD
Copy link
Contributor Author

psobolewskiPhD commented Aug 26, 2022

Hmm, so now it's the same symptom as napari-serialcellpose with macOS tests stalling:
guiwitz/napari-serialcellpose#8
Not sure why simply adding progress=True would do that...

Edit: The tests hang for my locally too, even though everything works when run in napari, so it's something related to qtbot/pytest-qt?

@psobolewskiPhD
Copy link
Contributor Author

psobolewskiPhD commented Oct 4, 2024

Grr, the hanging tests.
Happens locally on my mac too -- but everything works when running in napari.

❯ pytest .                
WARNING:root:openblas_set_num_threads not found
============================= test session starts ==============================
platform darwin -- Python 3.12.5, pytest-8.3.3, pluggy-1.5.0
PyQt5 5.15.11 -- Qt runtime 5.15.14 -- Qt compiled 5.15.14
rootdir: /Users/sobolp/Documents/dev/cellpose-napari
configfile: pyproject.toml
plugins: qt-4.4.0, napari-0.5.3, npe2-0.7.7, napari-plugin-engine-0.2.0
collected 3 items                                                              

tests/test_plugin.py ^C

Note: that control-C to interrupt wasn't successful, I had to kill the python processes -- there were 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants