Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] use resize_and_compute_masks in compute_masks #57

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

psobolewskiPhD
Copy link
Contributor

Closes #56

In this PR i replace using get_masks in compute_masks with resize_and_compute_masks. This results in minor additional refactor removing un-needed imports and function calls.

It appears to work correctly locally.

I will add a test once CI is fixed (#55)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.40%. Comparing base (ef6d108) to head (0d23ad4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cellpose_napari/_dock_widget.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   54.31%   61.40%   +7.09%     
==========================================
  Files           3        3              
  Lines         232      228       -4     
==========================================
+ Hits          126      140      +14     
+ Misses        106       88      -18     
Flag Coverage Δ
61.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carsen-stringer carsen-stringer merged commit c129834 into MouseLand:main Sep 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] recompute last masks button throws traceback
3 participants