-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added project name display using projectile #89
base: master
Are you sure you want to change the base?
Conversation
At a glance this seems cool! I'll review later when I get a chance to properly look at the code and try it out. Thanks for contributing! |
Ditto, I like the idea of project integration. Looks good but I'll review more in the morning. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll let @Zulu-Inuoe review as well 😄
Yep sorry about the delay. Had a busier Friday than expected. I did take another look and I'm good with it |
Great news! I was away for a few days so I couldn't reply. I thought a bit about the limitation of only being able to display either line numbers or the project name; maybe display the line numbers in short form after the buffer details line like so: Maybe an interesting idea ¯\_(ツ)_/¯. P.S.: I have very little knowledge about contributing to open source projects, so lets say I'm interested in trying to add said feature, would I just add commits to this request, or create a new one? Any help would be appreciated! |
Sorry! I thought I already replied to this! I think maybe the best answer is to provide some sort of hook for a user to be able to override the details in their own configuration. The default value for this function would produce the line number text, but adding projectile for example would be as simple as overriding this function with something else that returns the project name. Feel free to add to the current PR if you think that's something you'd like to work on. If not, I feel comfortable merging it. |
I've added a completely optional feature allowing users to display the name of the project the current buffer is in by using projectile. Projectile is a completely optional dependency here.
I've also changed the
elcord--details-and-state
function so that future additions would be easier.