New sticker find api that supports the new arguments sort and window and support integer sticker values #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcorporation
force-pushed
the
sticker_find_api
branch
from
2dda8b5
to
fba94c7
Compare
jcorporation
force-pushed
the
sticker_find_api
branch
2 times, most recently
from
244335e
to
35b4d6f
Compare
|
@MaxKellermann Do you want to review this pull request? I know I can merge it myself, but I would like your opinion on this bigger change. |
jcorporation
force-pushed
the
sticker_find_api
branch
3 times, most recently
from
7a719e0
to
c2a32b6
Compare
jcorporation
force-pushed
the
sticker_find_api
branch
from
c2a32b6
to
99f34af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves also some common search functions from src/search.c to src/isearch.c.