set of paths makes more sense and better tests

MusicalNinjaDad · Nov 15, 2023 · 1f71b50 · 1f71b50
1 parent db98e1f
commit 1f71b50
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/duplicates/dupes.py b/duplicates/dupes.py
@@ -7,7 +7,7 @@ def listfiles(in_path: Path) -> dict:
             filepath = root / file
             size = filepath.stat().st_size
             if size in filedict:
-                filedict[size].append(filepath)
+                filedict[size].add(filepath)
             else:
-                filedict[size] = [filepath]
+                filedict[size] = {filepath}
     return filedict
diff --git a/test/majorver/test_filedetails.py b/test/majorver/test_filedetails.py
@@ -25,15 +25,16 @@ def test_fileslisted(testfiles):
 def test_filesindexedbysize(testfiles):
     filesdict = listfiles(testfiles)
     assert filesdict == {
-        16: [Path(testfiles / 'dir1' / 'fileA.txt')],
-        23: [Path(testfiles / 'dir2' / 'fileB.txt')]
+        16: {Path(testfiles / 'dir1' / 'fileA.txt')},
+        23: {Path(testfiles / 'dir2' / 'fileB.txt')}
     }
 
 def test_filesofsamesize(duplicatedir1):
     testfiles = duplicatedir1
     filesdict = listfiles(testfiles)
     assert len(filesdict) == 2
-    assert Path(testfiles / 'dir1' / 'fileA.txt') in filesdict[16]
-    assert Path(testfiles / 'alt' / 'dir1' / 'fileA.txt') in filesdict[16]
-    assert len(filesdict[16]) == 2
-    assert filesdict[23] == [Path(testfiles / 'dir2' / 'fileB.txt')]
+    assert (filesdict[16]) == {
+        Path(testfiles / 'dir1' / 'fileA.txt'),
+        Path(testfiles / 'alt' / 'dir1' / 'fileA.txt')
+    }
+    assert filesdict[23] == {Path(testfiles / 'dir2' / 'fileB.txt')}