Fix CashTrickler revealing the location of cloaked actor with its text.

OpenRA.Mods.Common/Traits/CashTrickler.cs

@@ -33,6 +33,9 @@ public class CashTricklerInfo : PausableConditionalTraitInfo, IRulesetLoaded
 		[Desc("Whether to show the cash tick indicators rising from the actor.")]
 		public readonly bool ShowTicks = true;
 
+		[Desc("Show the cash tick indicators even if the unit is invisible due to Cloak trait.")]
+		public readonly bool ShowTicksWhileCloaked = false;
+
 		[Desc("How long to show the cash tick indicator when enabled.")]
 		public readonly int DisplayDuration = 30;
 
@@ -52,6 +55,7 @@ public class CashTrickler : PausableConditionalTrait<CashTricklerInfo>, ITick, I
 	{
 		readonly CashTricklerInfo info;
 		PlayerResources resources;
+		Cloak[] cloaks;
 		[Sync]
 		public int Ticks { get; private set; }
 
@@ -65,6 +69,7 @@ public CashTrickler(CashTricklerInfo info)
 		protected override void Created(Actor self)
 		{
 			resources = self.Owner.PlayerActor.Trait<PlayerResources>();
+			cloaks = self.TraitsImplementing<Cloak>().ToArray();
 
 			base.Created(self);
 		}
@@ -111,7 +116,7 @@ void ModifyCash(Actor self, int amount)
 					amount = resources.ChangeCash(amount);
 			}
 
-			if (info.ShowTicks && amount != 0)
+			if (info.ShowTicks && amount != 0 && (info.ShowTicksWhileCloaked || cloaks.Length == 0 || cloaks.All(c => c.IsVisible(self, self.World.RenderPlayer))))
 				AddCashTick(self, amount);
 		}
 	}