Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncation underline bridge #806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Truncation underline bridge #806

wants to merge 1 commit into from

Conversation

benalleng
Copy link
Collaborator

Closes #789

Before:
image

After:
image

@benalleng benalleng changed the title feat: add truncation bridge underline Truncation underline bridge Jan 8, 2024
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3667cfb
Status: ✅  Deploy successful!
Preview URL: https://104c4886.mutiny-web.pages.dev
Branch Preview URL: https://tx-underline.mutiny-web.pages.dev

View logs

@futurepaul
Copy link
Collaborator

doesn't look quite right on mac chrome. I haven't messed with this in a while but is there a reason we don't just use a <span>…</span> here?

Screenshot 2024-01-10 at 12 20 27 PM

@benalleng
Copy link
Collaborator Author

So a normal span doesn't work exactly as I want because the behavior of an overflow is to clip instead of delete characters so we end up with something like below when using <span>…</span> curious if you think you prefer this over trying to adjust the <hr/> for all browsers

image

@benalleng
Copy link
Collaborator Author

benalleng commented Jan 10, 2024

I tried setting a default underline offset as it seems like there is a difference between those defaults on firefox and chrome, I tested it myself on a few browsers but I haven't gotten a chance to test on mac

@futurepaul
Copy link
Collaborator

it's worse on safari for some reason:

Screenshot 2024-01-10 at 9 47 05 PM

So a normal span doesn't work exactly as I want because the behavior of an overflow is to clip instead of delete

ah, the pain is coming back to me lol

@futurepaul
Copy link
Collaborator

image

yeah maybe this can be fudged a bit with some margins or negative margins?

@benalleng benalleng force-pushed the tx-underline branch 9 times, most recently from 1828575 to 557ba0e Compare January 12, 2024 18:40
@benalleng
Copy link
Collaborator Author

benalleng commented Jan 12, 2024

Ok i tried again with some adjustments, I ended up not using relative with positioning and instead opted for a browser based negative margin, also tested on my girlfriend's iPhone and it looks like it worked! Let me know if you're cool with the browser based styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underline does not cover whole txid
3 participants