-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncation underline bridge #806
base: master
Are you sure you want to change the base?
Conversation
ffd9ee5
to
de46a5e
Compare
Deploying with Cloudflare Pages
|
de46a5e
to
899c501
Compare
I tried setting a default underline offset as it seems like there is a difference between those defaults on firefox and chrome, I tested it myself on a few browsers but I haven't gotten a chance to test on mac |
1828575
to
557ba0e
Compare
Ok i tried again with some adjustments, I ended up not using relative with positioning and instead opted for a browser based negative margin, also tested on my girlfriend's iPhone and it looks like it worked! Let me know if you're cool with the browser based styling |
557ba0e
to
0361403
Compare
0361403
to
3667cfb
Compare
Closes #789
Before:
After: