Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward more information to WolframAlpha #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nielstron
Copy link

@nielstron nielstron commented Jan 5, 2018

The user now has the choice to provide additional data to the wolframalpha knowledge engine.
This feature only works if either the official Mycroft api gets updated or the user provides his own appID.

Given the official api gets upgraded or you enter an api_key in the config file wolframalpha now receives plenty of additional data.
Assumptions based on your settings for date formats
Location based on your settings in home.mycroft, given you add the key 'forward_location' : true to the configuration
Automatic unit conversion based on your preferences in home.mycroft

Given the official api gets upgraded or you enter an api_key in the config file wolframalpha now receives plenty of additional data.
[Assumptions](https://products.wolframalpha.com/api/documentation/#assumption-DateOrder) based on your settings for date formats
[Location](https://products.wolframalpha.com/api/documentation/#specifying-your-location) based on your settings in home.mycroft, given you add the key 'forward_location' : true to the configuration
[Automatic unit conversion](https://products.wolframalpha.com/api/documentation/#top) based on your preferences in home.mycroft
@nielstron nielstron changed the title Giving the possibility to provide more info Forward more information to WolframAlpha Jan 5, 2018
@penrods
Copy link
Collaborator

penrods commented Jan 5, 2018

I like this idea! A couple comments and thoughts on the implementation:

  • I want to avoid telling users to manually edit their mycroft.conf file (which is really an old mechanism that exists for historical reasons). If it is experimental, you can talk about it in comments (which programmers would read), but I'd rather move all options toward the skill settings and the settingsjson.meta.

  • The settingsmeta.json doesn't support checkboxes yet (that is on the plate for @augustnmonteiro to do soon!). For today we need to present a "text" field where the user can type "true" or "false" based on clear instructions in a label above it. Then in the future you can easily switch the data type to a "bool" (checkbox) once that is available.

You can see an example of settingsmeta.json in the weather skill:
https://github.com/MycroftAI/skill-weather/blob/master/settingsmeta.json
In this case I used explicit instructions in place of a combobox with three options.

@penrods
Copy link
Collaborator

penrods commented Jan 5, 2018

One more thing, @nielstron -- thanks for helping with the Mycroft project! We do welcome
everyone into the community and greatly appreciate your help as we work to
build this AI for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code contribution.
This agreement makes it crystal clear that along with your code you are
offering a license to use it within the confines of this project. You retain
ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

@nielstron
Copy link
Author

Okay I'd happy to help, in the end my mycroft is working better too ;)

I have signed the Agreement, my username should appear on the list shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants