[Traffic Control] Support on bridge node #19291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
longbowlu
reviewed
Sep 13, 2024
|
|
||
| let (server_config, client_config) = config.validate(bridge_metrics.clone()).await?; | ||
| let traffic_controller = server_config.policy_config.map(|policy_config| { | ||
| Arc::new(TrafficController::spawn( |
There was a problem hiding this comment.
in a future PR, we will decide whether to spawn or init based on the actual acl policy?
There was a problem hiding this comment.
Yep, once I merge and rebase on the other PR which introduces the spawn/init, this logic will no longer be valid since spawn should no longer be public, and will need to be replaced with init, which will do the right thing based on the policy
| @@ -489,87 +547,154 @@ async fn handle_add_tokens_on_evm( | |||
| String, | |||
| String, | |||
| String, | |||
| )>, | |||
| )>, | |||
longbowlu
approved these changes
Sep 13, 2024
williampsmith
force-pushed
the
william/traffic-control-on-bridge-node
branch
from
64189ad
to
78de8cc
Compare
williampsmith
force-pushed
the
william/traffic-control-on-bridge-node
branch
from
78de8cc
to
fbc7cf4
Compare
suiwombat
approved these changes
Sep 20, 2024
williampsmith
force-pushed
the
william/traffic-control-on-bridge-node
branch
from
1e120c5
to
e5c9bd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Step 1 of adding traffic controller support in bridge node. This version only supports socket address based IPs. Followup PRs:
Test plan
TODO (soon)
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.