Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sui_proxy/pod health] #19416

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[sui_proxy/pod health] #19416

merged 3 commits into from
Sep 18, 2024

Conversation

suiwombat
Copy link
Contributor

@suiwombat suiwombat commented Sep 17, 2024

Description

  • add a route for pod health in k8s

i am using the consumer_operations_submitted value but more values can be added later if we need to. when this value is non-zero, it means the service is processing data correctly and can be used to consider it healthy enough to handle traffic. it will be implemented as a liveness check.

Test Plan

local


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@suiwombat suiwombat requested a review from a team September 17, 2024 16:58
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 9:24pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:24pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:24pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:24pm

@chris-gorham
Copy link
Contributor

will this be a health or ready check?

## Description
* add a route for pod health in k8s

i am using the consumer_operations_submitted value but more values can
be added later if we need to.  when this value is non-zero, it means the
service is processing data correctly and can be used to consider it
healthy enough to handle traffic.

## Test Plan
local
@suiwombat
Copy link
Contributor Author

will this be a health or ready check?

liveness

@suiwombat suiwombat enabled auto-merge (squash) September 18, 2024 21:34
@suiwombat suiwombat merged commit f2ab91e into main Sep 18, 2024
47 of 48 checks passed
@suiwombat suiwombat deleted the jh/sui_proxy_health_check branch September 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants