feat(json-rpc): get transaction block raw effects #19438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description
Add the ability to get transaction effects in BCS form, from JSON-RPC's
read path, by passing the `showRawEffects` option.
## Test plan
```
sui$ cargo build --bin sui --features indexer
sui$ $SUI start --force-regenesis --with-indexer --with-graphql --with-faucet
```
Then in another session:
```
sui$ $SUI client faucet
```
Find the transaction `$DIGEST` of the faucet transaction, and then fetch it
with:
```
curl -LX POST "http://localhost:9000" \
--header 'Content-Type: application/json' \
--data-raw '{
"jsonrpc": "2.0",
"method": "sui_getTransactionBlock",
"id": 1,
"params": ["'$DIGEST'", { "showRawEffects": true }]
}' | jq .
```
And corroborate it against the following GraphQL query:
```
query ($digest: String!) {
transactionBlock(digest: $digest) {
effects { bcs }
}
}
```
Which can be requested at `localhost:9125`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tzakian
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to get transaction effects in BCS form, from JSON-RPC's read path, by passing the
showRawEffectsoption.Test plan
Then in another session:
Find the transaction
$DIGESTof the faucet transaction, and then fetch it with:And corroborate it against the following GraphQL query:
Which can be requested at
localhost:9125.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
sui_getTransactionBlockandsui_multiGetTransactionBlockJSON-RPC endpoints will now heed theshowRawEffectsoption, and return the BCS representation of the transaction effects.