fix(indexer-alt): connection timeout default #20152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Using `stringify!(DEFAULT...)` doesn't work, because it stringifies the constant name, not its contents. This change uses `const_str::format` to do the same thing instead. ## Test plan Run the indexer without supplying a connection timeout. Before this change it would fail with a parse int error, because it tried to interpret the string `DEFAULT_CONNECTION_TIMEOUT_SECS` as an integer.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
stringify!(DEFAULT...)doesn't work, because it stringifies the constant name, not its contents. This change usesconst_str::formatto achieve what was originally intended.Test plan
Run the indexer without supplying a connection timeout. Before this change it would fail with a parse int error, because it tried to interpret the string
DEFAULT_CONNECTION_TIMEOUT_SECSas an integer.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.