[Consensus] Core to read last proposed round from DagState #20173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
akichidis
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
akichidis
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
arun-koshy
approved these changes
Nov 5, 2024
mwtian
approved these changes
Nov 5, 2024
consensus/core/src/core.rs
Outdated
| }); | ||
| assert!(our_ancestor_included.is_some()); | ||
| let our_ancestor_included = block | ||
| .ancestors() |
There was a problem hiding this comment.
Blocks proposed by Core should have the 1st ancestor as own ancestor.
akichidis
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Yes. If it's going to be a hassle @arun-koshy I can hold of until you merge, although the changes are quite small. |
Either way is fine with me! Feel free to merge and I can rebase as I am still waiting for approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring Core to read the last proposed block from DagState rather than local cached value. This change:
Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.