Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Update source coverage gathering so we don't include any duplicate source spans #20183

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Nov 5, 2024

Description

Hardens source coverage gathering to be resilient to duplicate source spans from the compiler. (e.g., from macros and the like).

Fixes issue #20075

Test plan

Manually tested on a failing test case.

@tzakian tzakian requested a review from a team November 5, 2024 20:11
@tzakian tzakian temporarily deployed to sui-typescript-aws-kms-test-env November 5, 2024 20:11 — with GitHub Actions Inactive
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 8:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Nov 5, 2024 8:12pm
sui-kiosk ⬜️ Ignored (Inspect) Nov 5, 2024 8:12pm
sui-typescript-docs ⬜️ Ignored (Inspect) Nov 5, 2024 8:12pm

Copy link
Contributor

@cgswords cgswords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the indexmap works how I expect it to.

@tzakian tzakian merged commit 696bb48 into main Nov 5, 2024
52 checks passed
@tzakian tzakian deleted the tzakian/dedup-source-coverage branch November 5, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants