indexer-alt: treat None as NULL #20704
Open
+4
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Pick out this change from the bigger #20482. `DEFAULT VALUE` is not something we use, and treating `None` as `DEFAULT VALUE` means we have to prepare different statements for each insert/update based on where the `None`'s appear. By treating `None` as `NULL`, we get to re-use prepared statements more, and the query sampler will do a better job grouping similar inserts/updates. ## Test plan Run indexer on coin balances and object info, locally, for the first 10,000 checkpoints.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
commented
Dec 20, 2024
There was a problem hiding this comment.
This was a straggler file from a previous refactor -- the real version of this file is lib.rs in the same directory.
wlmyng
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick out this change from the bigger #20482.
DEFAULT VALUEis not something we use, and treatingNoneasDEFAULT VALUEmeans we have to prepare different statements for each insert/update based on where theNone's appear.By treating
NoneasNULL, we get to re-use prepared statements more, and the query sampler will do a better job grouping similar inserts/updates.Test plan
Run indexer on coin balances and object info, locally, for the first 10,000 checkpoints.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.