Rename 'foo-procedures' to 'banana-procedures' #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These procedures use the Bananation mission model, not the Foo mission model
Mythicaeda
added
the
refactor
JoelCourtney
approved these changes
Nov 19, 2024
...c/main/java/gov/nasa/ammos/aerie/procedural/examples/bananaprocedures/constraints/Hello.java
Outdated
Show resolved
Hide resolved
Was used as an early test of Jar building before there were goal classes, but is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These procedures use the Bananation mission model, not the Foo mission model. The old module name was confusing.
Verification
I was able to build the module using the command in the README. I also did a project-wide search and found no other instances of either
foo-proceduresorfooproceduresDocumentation
I saw no mention of this module in the Aerie Docs website and have updated the README to use the new name.