Fixing puppet-lint issues

NASA-AMMOS · Apr 3, 2024 · a2a2acd · a2a2acd
1 parent cdde86a
commit a2a2acd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/puppet/modules/anms/manifests/docker.pp b/puppet/modules/anms/manifests/docker.pp
@@ -9,8 +9,8 @@
         ensure => 'absent',
         before => Package['docker-ce'],
       }
-
     }
+    default: {}
   }
 
   package { 'yum-utils':
@@ -20,7 +20,7 @@
     ensure => 'absent',
   }
   exec { 'yum-repo-docker-ce':
-    path => $::path,
+    path    => $facts['path'],
     command => 'yum-config-manager --add-repo https://download.docker.com/linux/rhel/docker-ce.repo',
     creates => '/etc/yum.repos.d/docker-ce.repo',
   }

diff --git a/puppet/modules/anms/manifests/docker_compose.pp b/puppet/modules/anms/manifests/docker_compose.pp
@@ -18,16 +18,19 @@
   case $ensure {
     'present': {
       exec { "docker-compose-${title}-up":
-        path => $::path,
-	command => "docker compose -p ${title} -f ${files_args} up --detach --remove-orphans ${up_args}",
+        path => $facts['path'],
+  command    => "docker compose -p ${title} -f ${files_args} up --detach --remove-orphans ${up_args}",
       }
     }
     'absent': {
       exec { "docker-compose-${title}-up":
-        path => $::path,
+        path    => $facts['path'],
         command => "docker compose -p ${title} -f ${files_args} rm --force --stop",
-	onlyif => $is_running,
+  onlyif        => $is_running,
       }
     }
+    default: {
+      fail("Invalid ensure argument: ${ensure}")
+    }
   }
 }