Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Attempt to activate coveralls #3

Merged
merged 7 commits into from
Oct 29, 2019
Merged

Conversation

tomdonaldson
Copy link
Contributor

No description provided.

@stargaser
Copy link
Contributor

I notice that in the development astropy that in conftest.py, instead of

from astropy.tests.plugins.display import (pytest_report_header,

there is now

from pytest_astropy_header.display import (pytest_report_header,

I tried to push this to this branch, but I don't have permission. Maybe we don't have "allow edits from maintainers" turned on?

@stargaser
Copy link
Contributor

Ah, I can push to this branch after all! I made a git error on the command line before (of course!).

@stargaser
Copy link
Contributor

For my next try, I have commented out the test against Astropy LTS (Long Term Support) which is currently v2.x. Once Astropy 4.0 is out, it becomes the LTS version and then we can re-enable this test.

@stargaser stargaser requested a review from ceb8 October 29, 2019 01:58
@ceb8 ceb8 merged commit 95afb21 into NASA-NAVO:master Oct 29, 2019
@tomdonaldson
Copy link
Contributor Author

Thanks, @stargaser! Do you think this change to conftest.py is something that should be changed in the astropy/package-template?

@stargaser
Copy link
Contributor

stargaser commented Oct 29, 2019

@tomdonaldson I've opened #435 on the package-template repo. I'm not sure what is the best solution there, since pytest_astropy_header could be included as a required package to get around the problem, I think.

@stargaser
Copy link
Contributor

stargaser commented Oct 29, 2019

Let me try that again to see if Github magic works: I opened astropy/package-template#435 on the package-template repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants