Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support Airborne, Facility, Telescope #36

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Updates to support Airborne, Facility, Telescope #36

merged 5 commits into from
Nov 12, 2024

Conversation

jordanpadams
Copy link
Member

🗒️ Summary

Updates to support Airborne, Facility, Telescope

⚙️ Test Data and/or Report

Screenshot 2024-10-18 at 7 01 36 PM Screenshot 2024-10-18 at 7 16 36 PM Screenshot 2024-10-18 at 7 16 46 PM

To test, you, unfortunately, need to deploy a registry and load data

♻️ Related Issues

Resolves #35

@jordanpadams jordanpadams requested a review from a team as a code owner October 19, 2024 02:40
conn.setReadTimeout(5000);

int responseCode = conn.getResponseCode();
if (responseCode == 200) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We all recognize 200 by now; but if you wanted to avoid numeric codes, I think HttpUrlConnection.HTTP_OK is available 😇

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but:

To test, you, unfortunately, need to deploy a registry and load data

So this is based on code inspection only—take with a grain of salt!

@jordanpadams
Copy link
Member Author

Fixed build. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new landing pages for Airborne, Facility, and Telescope
2 participants