Fix code scanning alert no. 155: Log Injection #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jordanpadams
requested review from
tloubrieu-jpl,
alexdunnjpl and
al-niessner
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NASA-PDS/registry-api/security/code-scanning/155
To fix the log injection issue, we need to sanitize the user-provided input before logging it. The best way to do this is to remove any potentially harmful characters from the input string. Specifically, we should replace newline characters with spaces to prevent log forging. Additionally, we should ensure that the user input is clearly marked in the log entry to avoid confusion.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.