Retry resilience stopgap #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not necessarily intended for direct merge - @jordanpadams what's the intended process to build a version of harvest utilizing a snapshot version of registry-common with this update for provision to Dan/Irma? |
|
@alexdunnjpl once this PR is merged, we will need to manually trigger the unstable build on harvest to get a new SNAPSHOT created: https://github.com/NASA-PDS/harvest/actions/workflows/unstable-cicd.yaml we should wait ~30 minutes after this merge to do so though, just in case it takes some time for the new SNAPSHOT version to post on Maven central repo |
tloubrieu-jpl
requested changes
Oct 23, 2023
fix bug - non-decrementing recursive call after refactor
tloubrieu-jpl
approved these changes
Oct 23, 2023
|
@tloubrieu-jpl @jordanpadams could one of y'all please merge? I'm not authorized on this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Adds stopgap retry behaviour to
DataLoader.loadBatch(), as a tentative step toward resolution of NASA-PDS/harvest#125⚙️ Test Data and/or Report
Manually tested to ensure intended behaviour. Requires in-situ testing to determine whether this fixes the user issue.
♻️ Related Issues
addresses NASA-PDS/harvest#125