Fix/placemark rotation and tilt #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Change order of unitSquareTransform matrix operations to fix image stretching on rotation and apply correct pivot point. 2) Normalize unitSquareTransform matrix Z-range to prevent texture clipping on tilting.
PJHogan
approved these changes
Mar 27, 2022
PJHogan
previously approved these changes
Mar 27, 2022
…texture from protruding through the terrain. Fix placemarks altitude mode in PlacemarksMilStd2525Activity to be correctly rendered on the top of the surface. Use billboarding approach of placemarks rendering to prevent clipping by terrain as described in MIL-STD-2525C APPENDIX F.5.1.1.2.
ComBatVision
force-pushed
the
fix/placemark-rotation-and-tilt
branch
from
83a807b
to
49080c0
Compare
PJHogan
approved these changes
Mar 27, 2022
PJHogan
previously approved these changes
Mar 27, 2022
PJHogan
approved these changes
Mar 29, 2022
PJHogan
previously approved these changes
Mar 29, 2022
ComBatVision
force-pushed
the
fix/placemark-rotation-and-tilt
branch
from
4fa3549
to
e1165f3
Compare
PJHogan
previously approved these changes
Mar 29, 2022
ComBatVision
force-pushed
the
fix/placemark-rotation-and-tilt
branch
from
e1165f3
to
a9947ee
Compare
ComBatVision
force-pushed
the
fix/placemark-rotation-and-tilt
branch
from
a9947ee
to
9377485
Compare
…lector via return parameter instead of nulling PlacamerkAttributes.
PJHogan
approved these changes
Apr 23, 2022
PJHogan
previously approved these changes
Apr 23, 2022
PJHogan
previously approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Why Should This Be In Core?
Original code had incorrect placemark orientation processing logic and should be fixed.
Benefits
Now Placemarks are correctly rotated, tilted and located related to the terrain.
Partially implemented Placemark label code is now complete and can be used.
Potential Drawbacks
None
Applicable Issues
WorldWindEarth#31