-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEM diagnostics #250
TEM diagnostics #250
Conversation
Remove values not currently needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! However, I do have some concerns, particularly with making sure we are actually grabbing all of the model history files. If you have any questions or concerns with my change requests just let me know. Thanks!
@nusbaume I think I've tackled all your suggestions and have run a couple tests. Let me know if anything else needs addressing, thanks! |
This variable is unnecessary, so getting rid of it in config yaml files too
Also remove use_defaults variable
@nusbaume Last changes are in place if you want to review this again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking a lot better! I just have some (hopefully) final config variable checking and cleanup requests.
Also remove duplicate code block in adf_info.py
GitHub suggestions
GitHub suggestions
@nusbaume Can you take another look and see if this is all good now. I ran it with your suggested changes and it appears to work as intended for when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me now, so feel free to merge whenever you are ready. Thanks!
Now ADF won't die if missing any TEM files, only skip TEM plotting
This will calculate TEM files and plots for:
There are two scripts being added,
scripts/averaging/create_TEM_files.py
for reading in h4 history files, calculating TEM variables and creating new netcdf files. Andscripts/plotting/tem.py
for reading in either the newly created netcdf files, or existing TEM netcdf files and plotting.Update
adf_variable_defaults.yaml
with TEM variables, including Obs files and variable names.Update
config_cam_baseline_example.yaml
for TEM scriptsNOTE: If QBO is present, all variables will be calculated, if not, only
uzm
epfy
epfz
vtem
wtem
psitem
andutendepfd
will be calculated.NOTE: If there are different vertical levels between cases, currently the difference plots don't work. I am working towards a vertical and horizontal interpolation for TEM as noted in issue #225