Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mods to derive PRECT #260

Merged
merged 9 commits into from
Nov 3, 2023
49 changes: 44 additions & 5 deletions lib/adf_diag.py
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,9 @@ def call_ncrcat(cmd):
hist_str = 'cam.h0'
#End if

# get info about variables defaults
nusbaume marked this conversation as resolved.
Show resolved Hide resolved
res = self.variable_defaults

#Loop over cases:
for case_idx, case_name in enumerate(case_names):

Expand Down Expand Up @@ -510,12 +513,24 @@ def call_ncrcat(cmd):

#Loop over CAM history variables:
list_of_commands = []
for var in self.diag_var_list:
vars_to_derive = []
#create copy of var list that can be modified for derivable variables
diag_var_list = self.diag_var_list
for var in diag_var_list:
if var not in hist_file_var_list:
msg = f"WARNING: {var} is not in the file {hist_files[0]}."
msg += " No time series will be generated."
print(msg)
continue
vres = res[var]
nusbaume marked this conversation as resolved.
Show resolved Hide resolved
if "derivable_from" in vres:
constit_list = vres['derivable_from']
for constit in constit_list:
if constit not in diag_var_list:
diag_var_list.append(constit)
vars_to_derive.append(var)
continue
else:
msg = f"WARNING: {var} is not in the file {hist_files[0]}."
msg += " No time series will be generated."
print(msg)
continue

#Check if variable has a "lev" dimension according to first file:
has_lev = bool('lev' in hist_file_ds[var].dims)
Expand Down Expand Up @@ -592,6 +607,9 @@ def call_ncrcat(cmd):
#Now run the "ncrcat" subprocesses in parallel:
with mp.Pool(processes=self.num_procs) as mpool:
_ = mpool.map(call_ncrcat, list_of_commands)

if vars_to_derive:
self.derive_variables(vars_to_derive=vars_to_derive,ts_dir=ts_dir[case_idx])
#End with

#End cases loop
Expand Down Expand Up @@ -915,4 +933,25 @@ def setup_run_cvdp(self):
print('For CVDP information visit: https://www.cesm.ucar.edu/working_groups/CVC/cvdp/')
print(' ')

#########

def derive_variables(self,vars_to_derive=None,ts_dir=None):

"""
Derive variables acccording to steps given here. Since derivations will depend on the
variable, each variable to derive will need its own set of steps below.
Comment on lines +941 to +942
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is totally fine for now, but long-term I wonder if we can figure out a way to add the derivation equations to the variable defaults YAML file itself, and then simply have this function properly parse those equations to produce the derived variable. That way future users won't have to modify the core ADF python code if they want to add a new derived variable.

Thoughts? @brianpm @justin-richling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea...I am not sure how to implement it though.

"""

for var in vars_to_derive:
if var == "PRECT":
# PRECT can be found by simply adding PRECL and PRECC
# grab file names for the PRECL and PRECC files from the case ts directory
nusbaume marked this conversation as resolved.
Show resolved Hide resolved
constit_files = sorted(glob.glob(ts_dir+"/*PREC*"))
nusbaume marked this conversation as resolved.
Show resolved Hide resolved
# create new file name for PRECT
prect_file = constit_files[0].replace('PRECC','PRECT')
# append PRECC to the file containing PRECL
os.system(f"ncks -A -v PRECC {constit_files[0]} {constit_files[1]}")
# create new file with the sum of PRECC and PRECL
os.system(f"ncap2 -s 'PRECT=(PRECC+PRECL)' {constit_files[1]} {prect_file}")

###############
7 changes: 7 additions & 0 deletions lib/adf_variable_defaults.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@
# category -> The website category the variable will be placed under.
#
#
# DERIVING:
#
# derivable_from -> If not present in the available output files, the variable can be derived from
# other variables that are present (e.g. PRECT can be derived from PRECC and PRECL),
# which are specified in this list
#
# Final Note: Please do not modify this file unless you plan to push your changes back to the ADF repo.
# If you would like to modify this file for your personal ADF runs then it is recommended
# to make a copy of this file, make modifications in that copy, and then point the ADF to
Expand Down Expand Up @@ -445,6 +451,7 @@ PRECT:
obs_name: "ERAI"
obs_var_name: "PRECT"
category: "Hydrologic cycle"
derivable_from: ['PRECL','PRECC']

QFLX:
category: "Hydrologic cycle"
Expand Down