Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated CSS to be a little fancier #261

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

brianpm
Copy link
Collaborator

@brianpm brianpm commented Sep 27, 2023

This updates the style for:

  • the navigation bar
  • the tables
  • a few of the "grid" elements (to change font and give rounded corners)

Tested on Safari and Chrome-based browsers on MacOS.

Purely cosmetic changes, but I think they make the website a little nicer. If we want to discuss specific choices/colors, let me know.

@nusbaume nusbaume self-requested a review December 24, 2023 16:18
@nusbaume nusbaume added the website Having to do with the generated website label Dec 24, 2023
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple (optional) requests to remove commented-out lines.

lib/website_templates/adf_diag.css Outdated Show resolved Hide resolved
lib/website_templates/adf_diag.css Outdated Show resolved Hide resolved
removed commented lines per code review comments.
@brianpm
Copy link
Collaborator Author

brianpm commented Jan 8, 2024

Okay, I took out those commented lines. This should be good to go.

Copy link
Collaborator

@justin-richling justin-richling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some style, we can probably use this CSS other places too.

@justin-richling justin-richling merged commit 9a1f903 into NCAR:main Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Having to do with the generated website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants