Milestone 2.27.0 #2220
Merged
Milestone 2.27.0 #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.9 to 1.14.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.9...v1.14.3) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
- Create the initial DrawTool view and layout methods Issue #2180
- Still a WIP - Make draw tool work directly with Map model, independent of widget - Rename DrawTool to DrawToolView Issue #2180
- Add MapInteraction, GeoPoint and GeoBoundingBox models - Make the CesiumWidgetView methods smaller and more modular - Move Map model attributes to the MapInteraction model (selectedFeatures, currentPosition, currentScale, and currentViewExtent) - In MapAsset models, listen for changes to cesiumOptions and update Cesium model - In map connectors, don't use new models as defaults to avoid instantiating new models unnecessarily - Pass GeoPoint and GeoScale models directly to the ScaleBarView Issues #2189, #2180, #2187
Issues #2189, 2180
- Still needs methods to clear the polygon and stop drawing; proper UI; testing Issue #2180
- Add the GeoPoints collection, with methods for serializing to GeoJson - Add a model that listens to a GeoPoints collection and updates a CesiumVectorData model with new geometry - Use these in the DrawToolView - Enable clearing a polygon - Show on first click, line on second click, polygon on subsequent clicks Issue #2180
- Switch from GeoJson to CZML (improves ability to draw around poles) - Set up the DrawTool for actions like deleting & moving points, running a callback with user-created points as argument Issue #2180
- Fix issues with drawing polygons, including drawing polygons over poles - Allow drawn polygons to have properties set like other layers (color, opacity, etc) - When drawing, draw both points and polygons - Add CustomDataSource support - Greatly reduce the number of re-renders Cesium must do (improve map performance) - Add connectors between GeoPoints collection and polygons & points Entities Issues #2180 and #2189
- In CesiumVectorData, in the new runVisualizers method, re-run in cases where visualizers are waiting for an async process to complete. - Fixes issue with Cesium Geohashes not showing up - Add some missing JSDocs to CesiumVectorData Issue #2180
- Style draw tool buttons - Hide edit & delete point buttons for now (not implemented) - Enable configuring hiding a layer in the layer list - Fix issue with removing entities in CesiumVectorData Issue #2180
Add an ID to the polygon created when drawing on map so that it is updated when new points are added rather than creating a new one Issue #2180
Fix taxa persisting between editor sessions bug
Improve error handling of view service response
- Add min height to markdown sections with portals - Also rename methods from postRender to what they do, because backbone calls these methods automatically even though this isn't documented! fixes #2195
Prevent weird TOC placement in portals
again after content has been loaded. Fixes #2192
Adjust height of feature info panel in Cesium map
- Show validation error when N coord is less than S coord - Fix the HTML input pattern for decimal degrees (was throwing an error) - Add a test for reversed coords to the EMLGeoCoverage model spec Issue #2159
- Add validation rule to prevent bounding boxes from: containing the poles or crossing the anti-meridian - Add unit tests for the new validation rules Issue #2159
Prevent impossible & problematic coordinates from being entered in the editor
- For each error type, provide solutions for invalid geo coverages - Move error messages to an object in the model (rather than a switch statement) - Update tests to get error messages from the model Issue #2159
Draw on Cesium map feature
- Optionally show a help panel in the ToolbarView - The help panel can display navigation instructions and feedback text - All of this is configurable in the map config Issue #2173
Add navigation help & feedback instructions to Cesium map toolbar
Calculate zoom level based on bounding box and window size. Issue #2198
Fix issue with Google Map's display of small bounding boxes in Metadata View
…1.14.3 Bump nokogiri from 1.13.9 to 1.14.3 in /docs
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.9 to 1.15.4. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.9...v1.15.4) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…1.15.4 Bump nokogiri from 1.13.9 to 1.15.4 in /docs
- Update 'minima' from '~> 2.0' to '~> 2.5' (theme) - Bump 'jekyll-feed' from '~> 0.6' to '~> 0.15' (Atom feed generator) - Elevate 'tzinfo' from '~> 1.2' to '~> 2.0' (time zone library) - Update 'activesupport' from '6.0.6.1' to '7.1.1' (fixes security vulnerability) - Resolve additional dependencies to their latest compatible versions - Update Bundler version used to '2.4.21'
upgrade github-pages from 214 to 228 (docs)
rushirajnenuji
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Hey @robyngit - Tested this PR on my local instance and metacatui.test.dataone.org and all the changes look good.
I was unable to reproduce the error that we encountered last week (data catalog and cesium map keeps refreshing), so looks like your fix with moveStartAndCameraChange resolves the issue. 🎉
And delete some dev comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comprises all of the changes documented in milestone 2.27.0. Following review and after any issues are fixed, then the follow needs to be completed before merging to main:
@since x.x.xtags)