Move lat, long parsing and validations logic into GeoPoint #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic will be removed from Viewfinder in future commit.
yvonnesjy
reviewed
Mar 6, 2024
ianguerin
changed the base branch from
develop
to
feature-1796-places-autocomplete
robyngit
requested changes
Mar 6, 2024
| }); | ||
|
|
||
| describe("Detecting latitude, longitude in string", () => { | ||
| it('accepts empty string', () => { | ||
| expect(GeoPoint.couldBeLatLong('')).to.be.true; |
There was a problem hiding this comment.
why could an empty string be a lat, long pair? maybe it's just the name of the function that is confusing me.
There was a problem hiding this comment.
I just mean for this function to disqualify strings from being a lat,long pair and not necessarily that they are a lat,long pair. For example, "13" could be a lat,long pair, because it doesn't have any disqualifying characters in it, though it is not a valid lat,long pair.
yvonnesjy
approved these changes
Mar 6, 2024
ianguerin
force-pushed
the
feature-1796-pr-1
branch
from
a137d9e
to
733403b
Compare
Add type safety checks.
ianguerin
force-pushed
the
feature-1796-pr-1
branch
from
733403b
to
6e7892f
Compare
robyngit
requested changes
Mar 11, 2024
Co-authored-by: Robyn <[email protected]>
robyngit
merged commit 0b1ff8c
into
NCEAS:feature-1796-places-autocomplete
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic will be removed from Viewfinder in future commit.
#1796