Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed offer grace period #209

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Removed offer grace period #209

merged 1 commit into from
Mar 1, 2022

Conversation

CarlosMealha
Copy link
Contributor

@CarlosMealha CarlosMealha commented Feb 19, 2022

closes #204

@CarlosMealha CarlosMealha changed the title removed offer grace period Removed offer grace period Feb 19, 2022
@CarlosMealha CarlosMealha requested review from DoStini and removed request for DoStini February 19, 2022 22:43
@imnotteixeira
Copy link
Collaborator

Looks good, try running npm audit fix to try to fix the audit problem (make sure you are running with node 14)

@BrunoRosendo
Copy link
Member

I've tried to fix the audit but nodemailer-express-handlebars hasn't been updated yet (vulnerability in its only dependency). Should we just wait? @imnotteixeira

@imnotteixeira
Copy link
Collaborator

Let's see if this is solved this week. I pinged the package owner yads/nodemailer-express-handlebars#52 (comment)

Couldn't find an email, and seems like he's not active on twitter, so this is our best shot.

If this isn't solved, we can try bumping our node and npm versions, since in npmv8 we have an overrides option to override transitive dependency versions, to solve this.

@DoStini
Copy link
Member

DoStini commented Feb 23, 2022

I don't think the author of that published the most recent update yet

@BrunoRosendo
Copy link
Member

BrunoRosendo commented Feb 23, 2022

He updated it in GitHub but not yet in npm :/

@CarlosMealha CarlosMealha merged commit 5e779d0 into develop Mar 1, 2022
@CarlosMealha CarlosMealha deleted the fix/editGracePeriod branch March 1, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let Offers be edited regardless of grace period
4 participants