added protobufs instructions to Dockerfile #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaspalma
requested changes
Sep 30, 2024
django/entrypoint.sh
Outdated
|
|
||
| # Compile protobuf files | ||
| echo "Compiling protobuf files..." | ||
| protoc --python_out=generated ./protos/*.proto |
There was a problem hiding this comment.
I believe it's best to have ./protos/**/*.proto instead of just ./protos/*.proto.
With the ** we are able to better support a folder structure of proto files (for example, if we wanted to separate different .proto files in different folders.
django/entrypoint_prod.sh
Outdated
| @@ -7,6 +7,11 @@ until PGPASSWORD="${POSTGRES_PASSWORD}" psql -h "${POSTGRES_HOST}" -U "${POSTGRE | |||
| done | |||
| >&2 echo "PostgreSQL is up - executing command" | |||
|
|
|||
| # Compile protobuf files | |||
| echo "Compiling protobuf files..." | |||
| protoc --python_out=generated -I=./protos/ ./protos/*.proto | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.