Change account password #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add some sort of 2 factor authentication to this (by email for example) for security reasons. I'm not sure if this is possible right now or if we should let this for a future issue |
Is that something usual when changing passwords with the user logged in? It definitely needs to be done in #84 but I'm not sure of the normal flow of a password change |
|
@coutinho21 Is this ready for review? If so, please remove it from draft |
coutinho21
force-pushed
the
feature/change-password
branch
2 times, most recently
from
3a6e276
to
53d15a4
Compare
bdmendes
requested changes
Feb 20, 2023
src/main/kotlin/pt/up/fe/ni/website/backend/service/ErrorMessages.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/pt/up/fe/ni/website/backend/controller/AccountControllerTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/AccountService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/controller/AccountController.kt
Outdated
Show resolved
Hide resolved
coutinho21
force-pushed
the
feature/change-password
branch
3 times, most recently
from
ddf0ba4
to
c6947a4
Compare
❌ Deploy Preview for niaefeup-backend-docs failed.
|
coutinho21
force-pushed
the
feature/change-password
branch
from
c6947a4
to
b0283a4
Compare
|
Closing this pr due to rebasing issues, starting a new branch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85
The objective is to add a new endpoint to change an account's password.
Review checklist
docs/openapi.yml