Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicksort java #161

Closed
wants to merge 4 commits into from
Closed

Quicksort java #161

wants to merge 4 commits into from

Conversation

aleksandren
Copy link

@aleksandren aleksandren commented Oct 2, 2018

quicksort.java Add Quicksort on Java

Closed #150

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #{150}

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@sangamcse
Copy link
Member

Comment on 874476c, file bubble_sort/Python/Bubble_sort.py, line 8.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmptujilmdv/bubble_sort/Python/Bubble_sort.py
+++ b/tmp/tmptujilmdv/bubble_sort/Python/Bubble_sort.py
@@ -6,4 +6,5 @@
 
     return mas
 
+
 print(bubble_sort([4, 3, 2, 1]))

@sangamcse
Copy link
Member

Comment on 874476c, file bubble_sort/Python/Bubble_sort.py, line 9.

E305 expected 2 blank lines after class or function definition, found 1

Origin: PycodestyleBear (E305), Section: all.autopep8.

for i in range(len(mas)):
for j in range(len(mas) - 1, i, -1):
if mas[j] < mas[j-1]:
mas[j], mas[j-1] = mas[j-1], mas[j]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpd1qdvjsf/bubble_sort/Python/Bubble_sort.py
+++ b/tmp/tmpd1qdvjsf/bubble_sort/Python/Bubble_sort.py
@@ -4,4 +4,6 @@
             if mas[j] < mas[j-1]:
                 mas[j], mas[j-1] = mas[j-1], mas[j]
     return mas
+
+
 print(bubble_sort([4, 3, 2, 1]))

if mas[j] < mas[j-1]:
mas[j], mas[j-1] = mas[j-1], mas[j]
return mas
print(bubble_sort([4, 3, 2, 1]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E305 expected 2 blank lines after class or function definition, found 0

Origin: PycodestyleBear (E305), Section: all.autopep8.

@sangamcse
Copy link
Member

Comment on b768198, file bubble_sort/Python/Bubble_sort.py, line 6.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp7rkcukyt/bubble_sort/Python/Bubble_sort.py
+++ b/tmp/tmp7rkcukyt/bubble_sort/Python/Bubble_sort.py
@@ -4,4 +4,6 @@
             if mas[j] < mas[j-1]:
                 mas[j], mas[j-1] = mas[j-1], mas[j]
     return mas
+
+
 print(bubble_sort([4, 3, 2, 1]))

@sangamcse
Copy link
Member

Comment on b768198, file bubble_sort/Python/Bubble_sort.py, line 7.

E305 expected 2 blank lines after class or function definition, found 0

Origin: PycodestyleBear (E305), Section: all.autopep8.

@sangamcse
Copy link
Member

@aleksandren, It shows that you haven't read the contribution guidelines

@aleksandren
Copy link
Author

@sangamcse, I will issue in accordance with the requirements

@sangamcse
Copy link
Member

Closing since @udayvig asked for it first.

@sangamcse sangamcse closed this Oct 2, 2018
@aleksandren aleksandren deleted the quicksort_java branch October 2, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Algo] Quick Sort [Java]
2 participants