-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quicksort java #161
Quicksort java #161
Conversation
Comment on 874476c, file bubble_sort/Python/Bubble_sort.py, line 8. The code does not comply to PEP8. Origin: PEP8Bear, Section: The issue can be fixed by applying the following patch: --- a/tmp/tmptujilmdv/bubble_sort/Python/Bubble_sort.py
+++ b/tmp/tmptujilmdv/bubble_sort/Python/Bubble_sort.py
@@ -6,4 +6,5 @@
return mas
+
print(bubble_sort([4, 3, 2, 1])) |
Comment on 874476c, file bubble_sort/Python/Bubble_sort.py, line 9. E305 expected 2 blank lines after class or function definition, found 1 Origin: PycodestyleBear (E305), Section: |
for i in range(len(mas)): | ||
for j in range(len(mas) - 1, i, -1): | ||
if mas[j] < mas[j-1]: | ||
mas[j], mas[j-1] = mas[j-1], mas[j] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8
.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpd1qdvjsf/bubble_sort/Python/Bubble_sort.py
+++ b/tmp/tmpd1qdvjsf/bubble_sort/Python/Bubble_sort.py
@@ -4,4 +4,6 @@
if mas[j] < mas[j-1]:
mas[j], mas[j-1] = mas[j-1], mas[j]
return mas
+
+
print(bubble_sort([4, 3, 2, 1]))
if mas[j] < mas[j-1]: | ||
mas[j], mas[j-1] = mas[j-1], mas[j] | ||
return mas | ||
print(bubble_sort([4, 3, 2, 1])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E305 expected 2 blank lines after class or function definition, found 0
Origin: PycodestyleBear (E305), Section: all.autopep8
.
Comment on b768198, file bubble_sort/Python/Bubble_sort.py, line 6. The code does not comply to PEP8. Origin: PEP8Bear, Section: The issue can be fixed by applying the following patch: --- a/tmp/tmp7rkcukyt/bubble_sort/Python/Bubble_sort.py
+++ b/tmp/tmp7rkcukyt/bubble_sort/Python/Bubble_sort.py
@@ -4,4 +4,6 @@
if mas[j] < mas[j-1]:
mas[j], mas[j-1] = mas[j-1], mas[j]
return mas
+
+
print(bubble_sort([4, 3, 2, 1])) |
Comment on b768198, file bubble_sort/Python/Bubble_sort.py, line 7. E305 expected 2 blank lines after class or function definition, found 0 Origin: PycodestyleBear (E305), Section: |
@aleksandren, It shows that you haven't read the contribution guidelines |
@sangamcse, I will issue in accordance with the requirements |
Closing since @udayvig asked for it first. |
quicksort.java Add Quicksort on Java
Closed #150
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #{150}
By submitting this pull request I confirm I've read and complied with the
below declarations.
{Tag}: Add {Algorithm/DS name} [{Language}]
, notUpdate README.md
orAdded new code
.After you submit your pull request, DO NOT click the 'Update Branch' button.