quick_sort.cpp: Add QuickSort C++ #255

joao-p-marques · 2018-10-03T23:37:45Z

Closes #250

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #250

By submitting this pull request I confirm I've read and complied with the
below declarations.

I have read the Contribution guidelines and I am confident that my PR reflects them.
I have followed the commit guidelines for this project.
My code follows the standard code structure.
This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

Closes NITSkmOS#250

sangamcse · 2018-10-03T23:39:39Z

quicksort/Cpp/quick_sort.cpp

+using std::cout;
+
+void quick_sort(int a[], int left, int right) {
+


Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:40Z

quicksort/Cpp/quick_sort.cpp

+            i++;
+            j--;
+        }
+      };


You don't need a ; after a } [readability/braces] [4]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:40Z

quicksort/Cpp/quick_sort.cpp

+        quick_sort(a, left, j);
+      if (i < right)
+        quick_sort(a, i, right);
+


Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:41Z

quicksort/Cpp/quick_sort.cpp

+
+}
+
+int main(void){


Missing space before { [whitespace/braces] [5]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:42Z

quicksort/Cpp/quick_sort.cpp

+
+    quick_sort(a, 0, a_size-1);
+
+    for(int i=0; i<a_size; i++){


Missing spaces around = [whitespace/operators] [4]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:43Z

quicksort/Cpp/quick_sort.cpp

+
+    quick_sort(a, 0, a_size-1);
+
+    for(int i=0; i<a_size; i++){


Missing spaces around < [whitespace/operators] [3]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:43Z

quicksort/Cpp/quick_sort.cpp

+
+    quick_sort(a, 0, a_size-1);
+
+    for(int i=0; i<a_size; i++){


Missing space before ( in for( [whitespace/parens] [5]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:45Z

quicksort/Cpp/quick_sort.cpp

+
+    quick_sort(a, 0, a_size-1);
+
+    for(int i=0; i<a_size; i++){


Missing space before { [whitespace/braces] [5]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse · 2018-10-03T23:39:46Z

quicksort/Cpp/quick_sort.cpp

+    for(int i=0; i<a_size; i++){
+        cout << a[i] << " ";
+    }
+}


Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]

Origin: CPPLintBear, Section: all.cpplint.

sangamcse

Fix all the commented issues and update the README table. All in one commit only.
Ref: https://github.com/NITSkmOS/Algorithms/blob/master/GIT_BASICS.md#follow-up

sangamcse · 2018-10-04T05:06:32Z

quicksort/Cpp/quick_sort.cpp

@@ -0,0 +1,42 @@
+


Redundant line

Corrected erros from 1st commit. Closes NITSkmOS#250

joao-p-marques · 2018-10-04T09:17:28Z

Changes made.

sangamcse · 2018-10-19T19:12:25Z

@joao-p-marques checks are still failing

quick_sort.cpp adds QuickSort Algorithm

48ed23a

Closes NITSkmOS#250

sangamcse added process/pending_review difficulty/low hacktoberfest HACKTOBERFEST 2020 type/algo labels Oct 3, 2018

sangamcse reviewed Oct 3, 2018

View reviewed changes

sangamcse assigned joao-p-marques Oct 4, 2018

sangamcse added the lang/C++ label Oct 4, 2018

sangamcse requested changes Oct 4, 2018

View reviewed changes

quicksort/Cpp/quick_sort.cpp Outdated

@@ -0,0 +1,42 @@

Copy link

Member

sangamcse Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant line

sangamcse added process/wip Work in Progress and removed process/pending_review labels Oct 4, 2018

quick_sort.cpp Adds QuickSort Algorithm

305ef02

Corrected erros from 1st commit. Closes NITSkmOS#250

sangamcse added the process/pending_review label Oct 4, 2018

sangamcse mentioned this pull request Oct 8, 2018

Create quicksort.cpp #402

Closed

7 tasks

sangamcse force-pushed the master branch from f35e26b to 44d7f53 Compare October 18, 2018 21:03

sangamcse removed the process/pending_review label Oct 19, 2018

sangamcse added status/stale and removed difficulty/low hacktoberfest HACKTOBERFEST 2020 lang/C++ labels Oct 31, 2018

sangamcse removed process/wip Work in Progress type/algo status/stale labels Oct 31, 2018

sangamcse closed this Oct 31, 2018

Divyanshi0007 mentioned this pull request Oct 31, 2018

Added quicksort in C++ #514

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

quick_sort.cpp: Add QuickSort C++ #255

quick_sort.cpp: Add QuickSort C++ #255

joao-p-marques commented Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse Oct 3, 2018

sangamcse left a comment

sangamcse Oct 4, 2018

joao-p-marques commented Oct 4, 2018

sangamcse commented Oct 19, 2018

		using std::cout;

		void quick_sort(int a[], int left, int right) {

quick_sort.cpp: Add QuickSort C++ #255

quick_sort.cpp: Add QuickSort C++ #255

Conversation

joao-p-marques commented Oct 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sangamcse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joao-p-marques commented Oct 4, 2018

sangamcse commented Oct 19, 2018