selection_sort.cpp: Add cpp implementation for selection sort. #483

yashasingh · 2018-10-29T21:25:30Z

This commit adds the Cpp implementation of selection sort for NITSkmOS/Algorithms.

closes #482

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #482

By submitting this pull request I confirm I've read and complied with the
below declarations.

I have read the Contribution guidelines and I am confident that my PR reflects them.
I have followed the commit guidelines for this project.
My code follows the standard code structure.
This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

TravisBuddy · 2018-10-29T21:37:37Z

Hey @yashasingh,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d94ab390-dbc2-11e8-8e0f-4de0fcdedaae

selection_sort/Cpp/selection_sort.cpp

sangamcse · 2018-10-29T21:42:56Z

selection_sort/Cpp/selection_sort.cpp

+	cout << "Enter the length of the array (less than 100)- ";
+	cin >> n;
+	cout << "Enter space separated " << n << " numbers- ";
+	for(int i = 0;i < n; i++){


Missing space before { [whitespace/braces] [5]

Origin: CPPLintBear, Section: all.cpplint.

selection_sort/Cpp/selection_sort.cpp

sangamcse · 2018-10-29T21:42:58Z

selection_sort/Cpp/selection_sort.cpp

+	return 0;
+}
+
+void selection_sort(int arr[], int n){


Missing space before { [whitespace/braces] [5]

Origin: CPPLintBear, Section: all.cpplint.

selection_sort/Cpp/selection_sort.cpp

sangamcse · 2018-10-29T21:42:59Z

selection_sort/Cpp/selection_sort.cpp

+	int i, j, temp;
+	for(i = 0; i < n; i++)
+		for(j = i+1; j < n; j++){
+			if(arr[i]>arr[j]){


Missing spaces around > [whitespace/operators] [3]

Origin: CPPLintBear, Section: all.cpplint.

selection_sort/Cpp/selection_sort.cpp

TravisBuddy · 2018-10-29T21:53:35Z

Hey @yashasingh,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 14344410-dbc5-11e8-8e0f-4de0fcdedaae

TravisBuddy · 2018-10-29T21:58:48Z

Hey @yashasingh,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cdff9700-dbc5-11e8-8e0f-4de0fcdedaae

TravisBuddy · 2018-10-29T22:02:30Z

Hey @yashasingh,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 53429480-dbc6-11e8-8e0f-4de0fcdedaae

yashasingh · 2018-10-29T22:08:07Z

@sangamcse Please review my PR!

sangamcse

Also, update README table. Keep both README and selection_sort.cpp in the same commit.

selection_sort/Cpp/selection_sort.cpp

yashasingh · 2018-10-30T07:40:08Z

@sangamcse Please review!

sangamcse

Everything is fine except one in the README and your commit head is more than 50 characters and commit body is more than 72 characters. Make them correct

README.md

yashasingh · 2018-10-30T12:22:24Z

@sangamcse I have updated the commit message but regarding the redundant issue in README.md, the line was already poor indented. Updating the same reflects it as a bigger change.
you may refer README.md line 28 to notice the indentation.

sangamcse · 2018-10-30T12:23:45Z

Create one issue about README table. That will become one newcomer issue. And for this issue, remove the extra blank line that you have added. :)

yashasingh · 2018-10-30T12:48:18Z

@sangamcse Required changes have been made. Please review 🙂

sangamcse · 2018-10-30T17:42:38Z

README.md

@@ -71,4 +71,4 @@ Feel free to contact us at our [Gitter channel](https://gitter.im/NITSkmOS/algo)
 ## Notes

 Only project maintainers should merge a PR.
-Other members can add their reviews to a PR but the merging should be done by only a project maintainer.
+Other members can add their reviews to a PR but the merging should be done by only a project maintainer.


Now, what happened with this one?

This must have happened since this branch had conflicts due to prior merging of other PRs.

sangamcse · 2018-10-30T18:21:28Z

Also, rebase your branch

Implementation of Cpp selection sort for NITSkmOS/Algorithms. closes NITSkmOS#482

yashasingh · 2018-10-30T19:55:25Z

@sangamcse Branch rebased. Please review. 🙂

sangamcse · 2018-10-31T05:05:35Z

ack a5277bd

sangamcse · 2018-10-31T05:06:23Z

@sangamcse ff

sangamcse · 2018-10-31T05:06:25Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

sangamcse · 2018-10-31T05:08:21Z

Automated fastforward with GitMate.io was successful! 🎉

sangamcse added process/pending_review size/XS difficulty/low hacktoberfest HACKTOBERFEST 2020 lang/C++ type/algo labels Oct 29, 2018

sangamcse assigned yashasingh Oct 29, 2018

yashasingh force-pushed the selection_sort branch from bb08738 to e9a30b1 Compare October 29, 2018 21:41

sangamcse reviewed Oct 29, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Outdated Show resolved Hide resolved

sangamcse reviewed Oct 29, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Outdated Show resolved Hide resolved

sangamcse reviewed Oct 29, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Outdated Show resolved Hide resolved

sangamcse reviewed Oct 29, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Outdated Show resolved Hide resolved

sangamcse reviewed Oct 29, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Outdated Show resolved Hide resolved

yashasingh force-pushed the selection_sort branch from e9a30b1 to 648326d Compare October 29, 2018 21:46

sangamcse reviewed Oct 29, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Outdated Show resolved Hide resolved

sangamcse reviewed Oct 29, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Outdated Show resolved Hide resolved

yashasingh force-pushed the selection_sort branch from 648326d to 861f5b5 Compare October 29, 2018 21:50

yashasingh force-pushed the selection_sort branch from 861f5b5 to f587db5 Compare October 29, 2018 22:01

sangamcse requested changes Oct 30, 2018

View reviewed changes

selection_sort/Cpp/selection_sort.cpp Show resolved Hide resolved

sangamcse added process/wip Work in Progress and removed process/pending_review labels Oct 30, 2018

yashasingh force-pushed the selection_sort branch from f587db5 to 615f29b Compare October 30, 2018 07:12

yashasingh force-pushed the selection_sort branch 6 times, most recently from c44dc5e to 517f959 Compare October 30, 2018 07:36

sangamcse requested changes Oct 30, 2018

View reviewed changes

README.md Outdated Show resolved Hide resolved

yashasingh force-pushed the selection_sort branch 3 times, most recently from 3bc37ea to ecb4e10 Compare October 30, 2018 12:15

yashasingh force-pushed the selection_sort branch from ecb4e10 to 0650886 Compare October 30, 2018 12:47

sangamcse requested changes Oct 30, 2018

View reviewed changes

selection_sort.cpp: Add cpp selection sort.

a5277bd

Implementation of Cpp selection sort for NITSkmOS/Algorithms. closes NITSkmOS#482

yashasingh force-pushed the selection_sort branch from 0650886 to a5277bd Compare October 30, 2018 19:53

sangamcse added process/approved and removed process/pending_review labels Oct 31, 2018

sangamcse merged commit a5277bd into NITSkmOS:master Oct 31, 2018

sangamcse removed the process/approved label Oct 31, 2018

sangamcse deployed to github-pages October 31, 2018 05:07 View deployment

sangamcse added the process/approved label Oct 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

selection_sort.cpp: Add cpp implementation for selection sort. #483

selection_sort.cpp: Add cpp implementation for selection sort. #483

yashasingh commented Oct 29, 2018 •

edited

Loading

TravisBuddy commented Oct 29, 2018

sangamcse Oct 29, 2018

sangamcse Oct 29, 2018

sangamcse Oct 29, 2018

TravisBuddy commented Oct 29, 2018

TravisBuddy commented Oct 29, 2018

TravisBuddy commented Oct 29, 2018

yashasingh commented Oct 29, 2018

sangamcse left a comment

yashasingh commented Oct 30, 2018

sangamcse left a comment

yashasingh commented Oct 30, 2018

sangamcse commented Oct 30, 2018

yashasingh commented Oct 30, 2018

sangamcse Oct 30, 2018

yashasingh Oct 30, 2018

sangamcse commented Oct 30, 2018

yashasingh commented Oct 30, 2018

sangamcse commented Oct 31, 2018

sangamcse commented Oct 31, 2018

sangamcse commented Oct 31, 2018

sangamcse commented Oct 31, 2018

selection_sort.cpp: Add cpp implementation for selection sort. #483

selection_sort.cpp: Add cpp implementation for selection sort. #483

Conversation

yashasingh commented Oct 29, 2018 • edited Loading

TravisBuddy commented Oct 29, 2018

TravisBuddy Request Identifier: d94ab390-dbc2-11e8-8e0f-4de0fcdedaae

sangamcse Oct 29, 2018

Choose a reason for hiding this comment

sangamcse Oct 29, 2018

Choose a reason for hiding this comment

sangamcse Oct 29, 2018

Choose a reason for hiding this comment

TravisBuddy commented Oct 29, 2018

TravisBuddy Request Identifier: 14344410-dbc5-11e8-8e0f-4de0fcdedaae

TravisBuddy commented Oct 29, 2018

TravisBuddy Request Identifier: cdff9700-dbc5-11e8-8e0f-4de0fcdedaae

TravisBuddy commented Oct 29, 2018

TravisBuddy Request Identifier: 53429480-dbc6-11e8-8e0f-4de0fcdedaae

yashasingh commented Oct 29, 2018

sangamcse left a comment

Choose a reason for hiding this comment

yashasingh commented Oct 30, 2018

sangamcse left a comment

Choose a reason for hiding this comment

yashasingh commented Oct 30, 2018

sangamcse commented Oct 30, 2018

yashasingh commented Oct 30, 2018

sangamcse Oct 30, 2018

Choose a reason for hiding this comment

yashasingh Oct 30, 2018

Choose a reason for hiding this comment

sangamcse commented Oct 30, 2018

yashasingh commented Oct 30, 2018

sangamcse commented Oct 31, 2018

sangamcse commented Oct 31, 2018

sangamcse commented Oct 31, 2018

sangamcse commented Oct 31, 2018

yashasingh commented Oct 29, 2018 •

edited

Loading