Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection_sort.java: Creating Selection Sort Algorithm in Java #516

Closed
wants to merge 3 commits into from
Closed

selection_sort.java: Creating Selection Sort Algorithm in Java #516

wants to merge 3 commits into from

Conversation

texasfight
Copy link

@texasfight texasfight commented Nov 1, 2018

Creates a Selection Sort algorithm in Java, with an example array in the main() method.

Closes Issue (#379)

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #{ISSUE_NUMBER}

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@texasfight texasfight changed the title selection_sort.java selection_sort.java: Creating Selection Sort Algorithm in Java Nov 1, 2018
@sangamcse sangamcse added invalid This doesn't seem right and removed process/pending_review size/XS labels Nov 1, 2018
@sangamcse sangamcse closed this Nov 1, 2018
@texasfight
Copy link
Author

What was invalid about what I did? I followed all of your formatting and completed the project.

@sangamcse
Copy link
Member

First of all, it was assigned to someone and you started working before informing them. You never asked for the issue assignment which is mentioned in the contributing guidelines.

@sangamcse
Copy link
Member

I followed all of your formatting and completed the project.

No, you didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants