Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insertion sort java #75

Closed
wants to merge 10 commits into from
Closed

Insertion sort java #75

wants to merge 10 commits into from

Conversation

salif-04
Copy link

@salif-04 salif-04 commented Sep 30, 2018

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #63

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@sangamcse
Copy link
Member

Kindly squash your 3 commits into 1.
Check the guide http://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits

@salif-04
Copy link
Author

Done.

@sangamcse
Copy link
Member

@sangamcse rebase

@sangamcse
Copy link
Member

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@sangamcse
Copy link
Member

@salif-04, update readme table also

@sangamcse
Copy link
Member

Automated rebase with GitMate.io was successful! 🎉

@salif-04
Copy link
Author

salif-04 commented Oct 2, 2018

Is it open? Can I update the README.md now?

@sangamcse
Copy link
Member

@salif-04
Copy link
Author

salif-04 commented Oct 2, 2018

Updated the readme.

@sangamcse
Copy link
Member

@sangamcse rebase

@sangamcse
Copy link
Member

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@sangamcse
Copy link
Member

Automated rebase with GitMate.io was successful! 🎉

@SaashaJoshi
Copy link
Contributor

I don't have much experience with Java as of now. If you could please assign me some other issue!

@sangamcse
Copy link
Member

Hey @salif-04, are you on it? 😃

@salif-04
Copy link
Author

Yes..

@salif-04
Copy link
Author

I was a bit busy with my internals.. Now I'll fix it..

Copy link
Member

@sangamcse sangamcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase your local repo and sync with the original repo. And then you need to squash your commits. Check https://github.com/NITSkmOS/Algorithms/blob/master/GIT_BASICS.md for any kind of help or ping me on gitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right status/stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Algo] Insertion Sort [Java]
3 participants