fix shared libs, no CALLABLE_WGRIB2, wgrib2 utility calls wgrib2(..) 234, 213, 212 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlysonStahl-NOAA
requested changes
Oct 4, 2024
| @@ -99,14 +116,15 @@ if(USE_PNG) | |||
| endif() | |||
|
|
|||
| if(OpenMP_C_FOUND) | |||
| target_link_libraries(obj_lib PUBLIC OpenMP::OpenMP_C) | |||
| # target_link_libraries(obj_lib PUBLIC OpenMP::OpenMP_C) | |||
There was a problem hiding this comment.
The checks are failing because of undefined references to OpenMP. Did you mean to comment this out?
There was a problem hiding this comment.
example:
cmake -DCMAKE_PREFIX_PATH="/home/ed/local/netcdf-c-4.9.2;/some/other/place" ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wgrib2 utility calls wgrib2(..) .. so no need for compiling wgrib2.c
with/without CALLABLE_WGRIB2 which was needed for utility vs lib build
BUILD_SHARED_LIB now works but not for python,
Python required external libraries to be added to libwgrib2.so. Only way to do
that was to build libwgrib2.a and combine with other *.a libraries
BUILD_LIB now makes relocatable code for python support.
The ftn_api library was renamed from libwgrib2_api to libwgrib2_ftn_api
Since the build for fortran codes that call libwgrib2 will be changing, it seemed
the right time to change the name of the library to something more descriptive.
In the future, the build of wgrib2_lib and obj_lib can be combined to reduce build time.