Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove et_calc and pdm03 #599

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Remove et_calc and pdm03 #599

merged 4 commits into from
Aug 10, 2023

Conversation

mattw-nws
Copy link
Contributor

Builds on/requires #598. Closes #562

Additions

  • None

Removals

  • Pdm03 model, ET calculation algorithms, and associated data and tests.

Changes

  • Removes a good deal of specialized code for providing the ET calculation specially as a framework-provided (non-forcing) quantity.

Testing

  1. Passes all automated tests.

Screenshots

Notes

Todos

  • Documentation and example cleanup to follow

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@mattw-nws mattw-nws mentioned this pull request Aug 2, 2023
Merged
11 tasks
@mattw-nws mattw-nws marked this pull request as ready for review August 3, 2023 16:12
@mattw-nws mattw-nws self-assigned this Aug 3, 2023
PhilMiller
PhilMiller previously approved these changes Aug 8, 2023
View reviewed changes
robertbartel
robertbartel previously approved these changes Aug 10, 2023
View reviewed changes
@mattw-nws
The necessary changes to remove et_calc from the production code... t…
e0160a6 
…his commit should let ngen compile (and run!) but not the tests.
@mattw-nws
Remove ET/Pdm03 files
3bb0499
@mattw-nws
Tests now _build_ though don't yet pass. Mainly removed ET calc depen…
7fd14c9 
…dencies--but some tests were testing ET calc implicitly, so their values now change if using a different quantity for testing.
@mattw-nws
PRESUMED correct adjustmets to expected output--needs validation
a06f266
@mattw-nws mattw-nws dismissed stale reviews from robertbartel and PhilMiller via a06f266 August 10, 2023 15:30
@mattw-nws mattw-nws merged commit e250c8b into NOAA-OWP:master Aug 10, 2023
20 checks passed
mattw-nws pushed a commit to PhilMiller/NOAA-OWP-ngen that referenced this pull request Aug 15, 2023
@PhilMiller @mattw-nws
Abominate remaining 'using namespace std' from headers
928eee1 
Conflicts:
	include/realizations/catchment/Bmi_Module_Formulation.hpp

(Removed `check_internal_providers` method dropped in NOAA-OWP#599 - @mattw-nws )
mattw-nws added a commit to PhilMiller/NOAA-OWP-ngen that referenced this pull request Aug 15, 2023
@mattw-nws
Fix two more missing std:: introduced in NOAA-OWP#599
4011aa6
mattw-nws pushed a commit to PhilMiller/NOAA-OWP-ngen that referenced this pull request Aug 16, 2023
@PhilMiller @mattw-nws
Abominate remaining 'using namespace std' from headers
6198f0e 
Conflicts:
	include/realizations/catchment/Bmi_Module_Formulation.hpp

(Removed `check_internal_providers` method dropped in NOAA-OWP#599 - @mattw-nws )
mattw-nws added a commit to PhilMiller/NOAA-OWP-ngen that referenced this pull request Aug 16, 2023
@mattw-nws
Fix two more missing std:: introduced in NOAA-OWP#599
bdecbb3
PhilMiller added a commit to PhilMiller/NOAA-OWP-ngen that referenced this pull request Aug 21, 2023
@PhilMiller
Abominate remaining 'using namespace std' from headers
5066c5c 
Conflicts:
	include/realizations/catchment/Bmi_Module_Formulation.hpp

(Removed `check_internal_providers` method dropped in NOAA-OWP#599 - @mattw-nws )
PhilMiller pushed a commit to PhilMiller/NOAA-OWP-ngen that referenced this pull request Aug 21, 2023
@mattw-nws @PhilMiller
Fix two more missing std:: introduced in NOAA-OWP#599
93cdac9
mattw-nws pushed a commit that referenced this pull request Aug 22, 2023
@PhilMiller @mattw-nws
Abominate remaining 'using namespace std' from headers
f71da52 
Conflicts:
	include/realizations/catchment/Bmi_Module_Formulation.hpp

(Removed `check_internal_providers` method dropped in #599 - @mattw-nws )
mattw-nws added a commit that referenced this pull request Aug 22, 2023
@mattw-nws
Fix two more missing std:: introduced in #599
645fda1
@mattw-nws mattw-nws mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbartel robertbartel robertbartel approved these changes

@PhilMiller PhilMiller PhilMiller left review comments

@hellkite500 hellkite500 Awaiting requested review from hellkite500

Assignees

@mattw-nws mattw-nws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove internal ET capability
3 participants
@mattw-nws @PhilMiller @robertbartel