-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bmi_Adapter: drop 'StreamHandler output' #840
Bmi_Adapter: drop 'StreamHandler output' #840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the comments are nitpicks if anything. I'll wait to merge till tomorrow so there's a bit more visibility, since this might affect some in-dev PRs (i.e. Forcings Engine ones). Should be quick/easy changes for those though.
ce402ec
to
bb32d37
Compare
I just test-merged with your Forcings Engine PR branch, and found a couple missing headers. Added the |
Co-authored-by: Phil Miller - NOAA <[email protected]>
Co-authored-by: Phil Miller - NOAA <[email protected]>
Co-authored-by: Phil Miller - NOAA <[email protected]>
The entire hierarchy of classes below
Bmi_Adapter
takesStreamHandler output
as a constructor argument, and just passes it up the chain. The only places it was actually used was in a pair of re-initialization warnings.Changes
logging::warning
insteadBmi_Adapter::output
member that was otherwise unusedStreamHandler output
parameter from all class constructors in the hierarchyoutput
arguments used to fill those parameters in adapter construction callsTesting
Notes
Checklist