Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t-route integration tests requiring fiona #870

Closed
wants to merge 1 commit into from

Conversation

program--
Copy link
Contributor

geopandas<1.0.0 included fiona as a required dependency. However, since v1.0.0, they switched to using pyogrio as the default engine for I/O -- as a result, fiona is currently an unspecified dependency in t-route.

Changes

  • Include fiona in pip install call in CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller
Copy link
Contributor

Is there a corresponding fix for t-route itself?

@PhilMiller
Copy link
Contributor

I.e. is the right thing to do to add it to t-route's requirements.txt instead?

@program--
Copy link
Contributor Author

program-- commented Aug 14, 2024

Is there a corresponding fix for t-route itself?

Yeah, my brain is frazzled. I did this, but then just reached out to Sean a few minutes ago and realized the actual fix is just to add fiona to the pyproject.toml in troute.network 🤦

At the very least, the CI runs here show me that's all the issue is haha

EDIT: NOAA-OWP/t-route#827

@program-- program-- closed this Aug 14, 2024
@program-- program-- deleted the t-route-integration-fiona-patch branch August 21, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants