-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ngen-build Github Action to make sure 1.x numpy is used #891
Conversation
Updating Actions depending on numpy install to use pre-2.0 numpy version as is currently required for ngen builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't stop a downstream workflow from requesting numpy>=2.0.0
via inputs.additional_python_requirements
. IMO that is desirable. This seems like an appropriate place to use constraints.txt
. We should be able to enforce this behavior in all downstream workflows by setting the PIP_CONSTRAINT
environment variable to the constraints file.
I'm pretty sure that changes to actions within a PR aren't applied when actions are run for the PR. So we should expect to still see the failures in the checks that this PR is intended to address. Someone correct me if I'm wrong though. |
Using pip constraints to ensure any downstream `input.additional_python_requirements` that may be installed also are prevented from installing a problematic version.
Yeah, good catch @aaraney. I've modified the approach. I wanted to use an absolute path, and for lack of a more obvious place, I put the file in the root directory. Sanity check me to make sure I'm not failing to think of a good reason we should avoid that (or just a good reason to put it somewhere else). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @robertbartel
Updating Actions depending on numpy install to use pre-2.0 numpy version. Currently, CMake will raise an error if the found numpy version is >= 2.0.0.
Changes
numpy<2.0.0
Notes
This is going into the pending
release-0.3.0
branch. The included changes will eventually make their way intoproduction
andmaster
as part of other steps in the release process.Checklist
Target Environment support