-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EUSS Demand Flexibility Measures new lighting control measure and thermostat control updates #199
base: main
Are you sure you want to change the base?
Conversation
measure initiation add building type applicability update dispatch schedule generation for 1. 15min interval 2. different window determination methods single test passed
Add option for dimming method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments within code. Do the measure tests check for more than just success? If not, it would be good to add a test that checks for proper application. Additionally, add a link to the single model example when it's ready.
test_sets = [] | ||
|
||
# test: applicable building type | ||
test_sets << { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should replace the example models with the most recent 3.7 versions.
"Office" | ||
"Office", | ||
"Warehouse", | ||
"PrimarySchool", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there space types in schools that you are excluding? Is it reasonable to apply these to gyms, cafeteria, etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We assume a uniform applicability to all space type to simplify the measure (for now) with the following considerations:
- The control is applicable to the majority of spaces in the building;
- The overestimated potential of applying the measure would compensate the underestimated potentia - for example, the lights in corridor area could be dimmed more while the lights in gym should be dimmed less (or skipped) - and such trade-offs are assumed to have negligible impact on the overall performance (especially in stock level).
These are explained in the documentation as well (in the applicability section). Let me know your opinion on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI
update get sch ts from ruleset function update timezone function
Pull request overview
Code review for new and updated demand flexibility measures and tests
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File