Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test template and workflow measures #235

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Update test template and workflow measures #235

wants to merge 44 commits into from
+211,333 −497,202

Conversation

mdahlhausen
Copy link
Contributor

Pull request overview

This pull request updates the measure test template and models. Fixes #37.
It also fixes rubocop errors on all workflow measures. 1 error and several warnings remain that will not be changed.
It includes changes from #230 (not individual commits).

Pull Request Author

This pull request makes changes to:

  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Workflow Measures

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Updated measure .xml(s)
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Ensured code files contain License reference
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

mdahlhausen and others added 30 commits October 3, 2024 15:43
@mdahlhausen
add rubocop checks
a1bb0b8 
rubocop was already included in the gemspec. This adds a rake task to run rubocop on all ComStock ruby files.
@JanghyunJK
temp
fb8d638
@mdahlhausen
Update rake file and measure test rake tasks
3087057 
- split measure tests into reporting, workflow, and upgrade
- enforce rubocop standards on Gemfile and Rake file
- update README.md
@mdahlhausen
Merge branch 'develop' into mdahlhau/rubocop
b110584
@LandanT
Merge pull request #227 from NREL/mdahlhau/rubocop
92f46d3 
Add rubocop rake task
@mdahlhausen
Update .gitignore
ae0316e
@mdahlhausen
Update test_template.rb
9c57ceb
@mdahlhausen
update add_blinds_to_selected_windows test
79521cb
@mdahlhausen
update ChangeBuildingLocation tests
a59f6cf
@mdahlhausen
rubocop edits to add_blinds_to_selected_windows
67ddbfd
@mdahlhausen
update add_hvac_nighttime_operation_variability
90f803c
@mdahlhausen
update simulation_settings measure tests
a87d924
@mdahlhausen
update add thermostat_setpoint_variability_test
791f318
@mdahlhausen
update adjust_occupancy_schedule test
f5f98e2
@mdahlhausen
update fault_hvac_economizer_changeover_temperature
b0c02c8
@mdahlhausen
update fault_hvac_economizer_damper_stuck
a2c881e
@mdahlhausen
remove hvac_nighttime_oa_controls
e4f8bf2
@mdahlhausen
update replace_baseline_windows
68dd59f
@mdahlhausen
update set_electric_equipment_bpr
8fe1aeb
@mdahlhausen
update set_exterior_lighting_template
1f6586c
@mdahlhausen
update set_exterior_lighting_template
614c52b
@mdahlhausen
update set_heating_fuel
0b5f6e0
@mdahlhausen
update set_hvac_template
90a9173
@mdahlhausen
update set_interior_equipment_template
adb352e
@mdahlhausen
update set_interior_lighting_bpr
b20fbb6
@mdahlhausen
update set_interior_lighting_technology
339f73f
@mdahlhausen
update set_primary_kitchen_equipment
684e561
@mdahlhausen
update set_roof_template
ea33b6b
@mdahlhausen
update set_wall_template
13815b4
@mdahlhausen
update set_space_type_load_categories
30c2647
@mdahlhausen mdahlhausen added infrastructure PR improves or updates the build process and dependencies workflow measure PR improves or adds baseline workflow measures labels Oct 17, 2024
@mdahlhausen
Copy link
Contributor Author

Wait to merge until develop/main branches are synced.

@mdahlhausen mdahlhausen changed the base branch from develop to main October 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LandanT LandanT Awaiting requested review from LandanT

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
infrastructure PR improves or updates the build process and dependencies workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and Update Models for Measure Tests
3 participants
@mdahlhausen @JanghyunJK @LandanT