-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CppCheck OutputReportTabular #10740
Open
rraustad
wants to merge
21
commits into
develop
Choose a base branch
from
CppCheck-OutputReportTabular
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CppCheck OutputReportTabular #10740
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d738421
reduce, const and unused
rraustad 267101c
const memory location but values at that memory location can change
rraustad 880ee14
more const memory location
rraustad 4411799
const state arg
rraustad 7629f2a
const state arg
rraustad a526400
const and reduce
rraustad 3468d83
reduce, const and unused
rraustad 38fda30
always true conditionals
rraustad b2605d5
always true conditionals
rraustad 0ae2b06
reduce and unused
rraustad c2cfd78
reduce
rraustad 342fe70
reduce
rraustad c5875fd
reduce, const and unused
rraustad 44a687f
reduce, but really unused
rraustad 38d7850
reduce and const reference
rraustad 04cbd75
const real arg
rraustad b38588b
const real args
rraustad 4b5156d
const real arg
rraustad 8acf3ba
std::find_if
rraustad 37c2b5c
find_if and reduce
rraustad 42f793a
Revert argument change for NEWTON function
rraustad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,12 +95,12 @@ namespace Material { | |
Tau2 = this->deltaTempMeltingHigh; | ||
if (updatedTempTDT < TempLowPCM) { | ||
phaseChangeState = Phase::Crystallized; | ||
} else if (updatedTempTDT >= TempLowPCM && updatedTempTDT <= TempHighPCM) { | ||
} else if (updatedTempTDT <= TempHighPCM) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [src/EnergyPlus/PhaseChangeModeling/HysteresisModel.cc:98]:(style),[knownConditionTrueFalse],Condition 'updatedTempTDT>=TempLowPCM' is always true |
||
phaseChangeState = Phase::Melting; | ||
if (prevPhaseChangeState == Phase::Freezing || prevPhaseChangeState == Phase::Transition) { | ||
phaseChangeState = Phase::Transition; | ||
} | ||
} else if (updatedTempTDT > TempHighPCM) { | ||
} else { | ||
phaseChangeState = Phase::Liquid; | ||
} | ||
} else { // phaseChangeDeltaT > 0 | ||
|
@@ -109,12 +109,12 @@ namespace Material { | |
Tau2 = this->deltaTempFreezingHigh; | ||
if (updatedTempTDT < TempLowPCF) { | ||
phaseChangeState = Phase::Crystallized; | ||
} else if (updatedTempTDT >= TempLowPCF && updatedTempTDT <= TempHighPCF) { | ||
} else if (updatedTempTDT <= TempHighPCF) { | ||
phaseChangeState = Phase::Freezing; | ||
if (prevPhaseChangeState == Phase::Melting || prevPhaseChangeState == Phase::Transition) { | ||
phaseChangeState = Phase::Transition; | ||
} | ||
} else if (updatedTempTDT > TempHighPCF) { | ||
} else { | ||
phaseChangeState = Phase::Liquid; | ||
} | ||
} | ||
|
@@ -266,13 +266,11 @@ namespace Material { | |
return (Cp1 + DEta1); | ||
} else if (T == criticalTemperature) { | ||
return (EnthalpyNew - EnthalpyOld) / (temperatureCurrent - temperaturePrev); | ||
} else if (T > criticalTemperature) { | ||
} else { | ||
Real64 DEta2 = (this->totalLatentHeat * (T - criticalTemperature) * exp(-2 * std::abs(T - criticalTemperature) / tau2)) / | ||
(tau2 * std::abs(T - criticalTemperature)); | ||
Real64 Cp2 = this->specificHeatLiquid; | ||
return Cp2 + DEta2; | ||
} else { | ||
return 0; | ||
} | ||
} | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[src/EnergyPlus/OutsideEnergySources.cc:178]:(style),[knownConditionTrueFalse],Condition 'EnergySourceNum>NumDistrictUnitsHeatWater' is always true