Merge pull request #416 from NREL/os_warnings

OpenStudio warnings
NREL · Jun 8, 2020 · 59d4f1d · 59d4f1d
2 parents c8d099c + a2f4483
commit 59d4f1d
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 22 deletions.
diff --git a/HPXMLtoOpenStudio/measure.rb b/HPXMLtoOpenStudio/measure.rb
@@ -1959,19 +1959,19 @@ def self.apply_adiabatic_construction(runner, model, surfaces, type)
 
     if type == 'wall'
       Constructions.apply_wood_stud_wall(model, surfaces, 'AdiabaticWallConstruction',
-                                         0, 1, 3.5, true, 0.1, 0.5, 0, 999,
+                                         0, 1, 3.5, true, 0.1, 0.5, 0, 99,
                                          Material.ExtFinishStuccoMedDark, 0,
                                          Material.AirFilmVertical,
                                          Material.AirFilmVertical)
     elsif type == 'floor'
       Constructions.apply_floor(model, surfaces, 'AdiabaticFloorConstruction',
-                                0, 1, 0.07, 5.5, 0.75, 999,
+                                0, 1, 0.07, 5.5, 0.75, 99,
                                 Material.FloorWood, Material.CoveringBare,
                                 Material.AirFilmFloorReduced,
                                 Material.AirFilmFloorReduced)
     elsif type == 'roof'
       Constructions.apply_open_cavity_roof(model, surfaces, 'AdiabaticRoofConstruction',
-                                           0, 1, 7.25, 0.07, 7.25, 0.75, 999,
+                                           0, 1, 7.25, 0.07, 7.25, 0.75, 99,
                                            Material.RoofingAsphaltShinglesMed, false)
     end
   end
@@ -3397,7 +3397,7 @@ def self.apply_wall_construction(runner, model, surfaces, wall_id, wall_type, as
       end
       thick_ins = [thick_in]
       if layer_r == 0
-        conds = [999]
+        conds = [99]
       else
         conds = [thick_in / layer_r]
       end

diff --git a/HPXMLtoOpenStudio/measure.xml b/HPXMLtoOpenStudio/measure.xml
@@ -3,8 +3,8 @@
   <schema_version>3.0</schema_version>
   <name>hpxm_lto_openstudio</name>
   <uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
-  <version_id>f1a302ba-178a-49eb-816a-6e7dbd494ded</version_id>
-  <version_modified>20200606T195413Z</version_modified>
+  <version_id>a5ce68fd-ea64-4797-ae10-a9451c617fcc</version_id>
+  <version_modified>20200608T160112Z</version_modified>
   <xml_checksum>D8922A73</xml_checksum>
   <class_name>HPXMLtoOpenStudio</class_name>
   <display_name>HPXML to OpenStudio Translator</display_name>
@@ -432,12 +432,6 @@
       <usage_type>resource</usage_type>
       <checksum>C1F5918C</checksum>
     </file>
-    <file>
-      <filename>hvac_sizing.rb</filename>
-      <filetype>rb</filetype>
-      <usage_type>resource</usage_type>
-      <checksum>288744B9</checksum>
-    </file>
     <file>
       <filename>pv.rb</filename>
       <filetype>rb</filetype>
@@ -474,12 +468,6 @@
       <usage_type>test</usage_type>
       <checksum>35F0F6C6</checksum>
     </file>
-    <file>
-      <filename>airflow.rb</filename>
-      <filetype>rb</filetype>
-      <usage_type>resource</usage_type>
-      <checksum>35AE4150</checksum>
-    </file>
     <file>
       <filename>hpxml_defaults.rb</filename>
       <filetype>rb</filetype>
@@ -510,6 +498,18 @@
       <usage_type>resource</usage_type>
       <checksum>82B030F4</checksum>
     </file>
+    <file>
+      <filename>hvac_sizing.rb</filename>
+      <filetype>rb</filetype>
+      <usage_type>resource</usage_type>
+      <checksum>71561908</checksum>
+    </file>
+    <file>
+      <filename>airflow.rb</filename>
+      <filetype>rb</filetype>
+      <usage_type>resource</usage_type>
+      <checksum>ED8FFA02</checksum>
+    </file>
     <file>
       <version>
         <software_program>OpenStudio</software_program>
@@ -519,7 +519,7 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>253EEF7C</checksum>
+      <checksum>31C27844</checksum>
     </file>
   </files>
 </measure>
diff --git a/HPXMLtoOpenStudio/resources/airflow.rb b/HPXMLtoOpenStudio/resources/airflow.rb
@@ -1126,7 +1126,7 @@ def self.apply_infiltration_to_vented_attic(model, weather, vented_attic)
     volume = UnitConversions.convert(space.volume, 'm^3', 'ft^3')
     if not vented_attic_sla.nil?
       vented_attic_area = UnitConversions.convert(space.floorArea, 'm^2', 'ft^2')
-      hor_lk_frac = 1.0
+      hor_lk_frac = 0.75
       neutral_level = 0.5
       sla = vented_attic_sla
       ach = get_infiltration_ACH_from_SLA(sla, 8.202, weather)
@@ -1150,7 +1150,7 @@ def self.apply_infiltration_to_unvented_attic(model, weather)
     space = @spaces[HPXML::LocationAtticUnvented]
     area = UnitConversions.convert(space.floorArea, 'm^2', 'ft^2')
     volume = UnitConversions.convert(space.volume, 'm^3', 'ft^3')
-    hor_lk_frac = 1.0
+    hor_lk_frac = 0.75
     neutral_level = 0.5
     sla = 0 # Assumption
     ach = get_infiltration_ACH_from_SLA(sla, 8.202, weather)

diff --git a/HPXMLtoOpenStudio/resources/hvac_sizing.rb b/HPXMLtoOpenStudio/resources/hvac_sizing.rb
@@ -3392,7 +3392,7 @@ def self.set_object_values(model, hvac, hvac_final_values)
         coil = object.heatingCoil.to_CoilHeatingWaterBaseboard.get
         coil.setUFactorTimesAreaValue(bb_UA)
         coil.setMaximumWaterFlowRate(bb_max_flow)
-        coil.setHeatingDesignCapacityMethod('autosize')
+        coil.setHeatingDesignCapacityMethod('HeatingDesignCapacity')
 
         plant_loop.components.each do |component|
           # Boiler