Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split HPWHs #1172

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Split HPWHs #1172

wants to merge 3 commits into from

Conversation

jmaguire1
Copy link
Collaborator

@jmaguire1 jmaguire1 commented Sep 8, 2022

Split HPWHs

Addresses #1170. Adding functionality to model split HPWHs. Two products will be modeled in the initial implementation: A Chinese AO Smith split HPWH and a SanCO2. The Chinese unit is coming to the US market soon and uses the same refrigerant as integrated HPWHs (with refrigerant being circulated), while the SanCO2 uses CO2 and circulates water.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Unit tests have been added/updated (e.g., HPXMLtoOpenStudio/tests)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@jmaguire1 jmaguire1 self-assigned this Sep 8, 2022
@jmaguire1 jmaguire1 marked this pull request as draft September 8, 2022 17:50
@shorowit shorowit added the enhancement New feature or request label Sep 13, 2022
@shorowit shorowit mentioned this pull request Sep 14, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority medium
Projects
Status: Blocker/On Hold
Development

Successfully merging this pull request may close these issues.

2 participants