Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow instantaneous water heaters w/ larger tank volumes #1860

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Allow instantaneous water heaters w/ larger tank volumes #1860

wants to merge 5 commits into from

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 16, 2024 •
edited
Loading

Pull Request Description

Closes #1858.

  • Renames "tankless" to "instantaneous" in code and sample files
  • Allow HeatingCapacity input
  • Allow TankVolume input
  • Change PerformanceAdjustment default?

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Oct 16, 2024
@shorowit shorowit self-assigned this Oct 16, 2024
Base automatically changed from hpwh_capacities to master October 16, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
enhancement New feature or request
Projects
OpenStudio-HPXML
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow instantaneous water heaters w/ larger tank volumes
1 participant
@shorowit